Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2685813003: iOS: Fix breakage caused by buildbot recipe update (Closed)

Created:
3 years, 10 months ago by kjellander_webrtc
Modified:
3 years, 10 months ago
Reviewers:
smut
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS: Fix breakage caused by buildbot recipe update Similar changes as in https://codereview.chromium.org/2659123003 Our MB configuration is still the actually used build config for these bots. BUG=686304 TBR=smut@google.com Review-Url: https://codereview.webrtc.org/2685813003 . Cr-Commit-Position: refs/heads/master@{#16486} Committed: https://chromium.googlesource.com/external/webrtc/+/5e5a072f2c405e355e5e481f8dd784d84f4b2dce

Patch Set 1 #

Patch Set 2 : Added target_cpu as well #

Patch Set 3 : Proper strings for target_cpu #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -56 lines) Patch
M tools-webrtc/ios/client.webrtc/iOS32_Debug.json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M tools-webrtc/ios/client.webrtc/iOS32_Release.json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M tools-webrtc/ios/client.webrtc/iOS32_Sim_Debug_(iOS_9.0).json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M tools-webrtc/ios/client.webrtc/iOS64_Debug.json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M tools-webrtc/ios/client.webrtc/iOS64_Release.json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M tools-webrtc/ios/client.webrtc/iOS64_Sim_Debug_(iOS_10.0).json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M tools-webrtc/ios/client.webrtc/iOS64_Sim_Debug_(iOS_9.0).json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios32_sim_ios9_dbg.json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios64_sim_ios10_dbg.json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios64_sim_ios9_dbg.json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios_arm64_dbg.json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios_arm64_rel.json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios_dbg.json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M tools-webrtc/ios/tryserver.webrtc/ios_rel.json View 1 2 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
kjellander_webrtc
Committed patchset #3 (id:10014) manually as 5e5a072f2c405e355e5e481f8dd784d84f4b2dce (presubmit successful).
3 years, 10 months ago (2017-02-08 11:04:26 UTC) #2
smut
3 years, 10 months ago (2017-02-08 22:46:51 UTC) #3
Message was sent while issue was closed. 
lgtm

Sorry about that. I remembered the webrtc/ios recipe but I forgot the actual
configs in the webrtc repository.

Powered by Google App Engine
This is Rietveld 408576698