Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2685583009: Make functions in fileutils.h use "const std::string&". (Closed)

Created:
3 years, 10 months ago by ehmaldonado_webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make functions in fileutils.h use "const std::string&". This way, the strings are not copied everytime the function is called. BUG=webrtc:7142 NOTRY=True Review-Url: https://codereview.webrtc.org/2685583009 Cr-Commit-Position: refs/heads/master@{#16537} Committed: https://chromium.googlesource.com/external/webrtc/+/88df0bc5912d55ab272a1b352e2ae80e6e7668c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M webrtc/test/testsupport/fileutils.h View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/test/testsupport/fileutils.cc View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
ehmaldonado_webrtc
3 years, 10 months ago (2017-02-10 12:56:08 UTC) #2
kjellander (google.com)
lgtm
3 years, 10 months ago (2017-02-10 13:25:22 UTC) #4
kjellander_webrtc
lgtm with the right account Please reference a bug.
3 years, 10 months ago (2017-02-10 13:26:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2685583009/1
3 years, 10 months ago (2017-02-10 17:23:42 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 17:27:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/88df0bc5912d55ab272a1b352...

Powered by Google App Engine
This is Rietveld 408576698