Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2685533002: Replace occurences of string by std::string. (Closed)

Created:
3 years, 10 months ago by ehmaldonado_webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace occurences of string by std::string. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2685533002 Cr-Commit-Position: refs/heads/master@{#16463} Committed: https://chromium.googlesource.com/external/webrtc/+/1b21b9bbf8e9d3911dba39ab09ee3d3398975c49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/base/base64_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ehmaldonado_webrtc
3 years, 10 months ago (2017-02-07 11:00:33 UTC) #2
kjellander_webrtc
How can we prevent them from coming back? I suggest we make a PRESUBMIT check ...
3 years, 10 months ago (2017-02-07 11:18:44 UTC) #3
henrika_webrtc
lgtm
3 years, 10 months ago (2017-02-07 11:36:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2685533002/1
3 years, 10 months ago (2017-02-07 11:38:12 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 11:40:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1b21b9bbf8e9d3911dba39ab0...

Powered by Google App Engine
This is Rietveld 408576698