Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2685503002:
Fix for flaky RemoveOverheadFromBandwidth test. (Closed)
DescriptionFix for flaky RemoveOverheadFromBandwidth test.
BUG=webrtc:6886
Review-Url: https://codereview.webrtc.org/2685503002
Cr-Commit-Position: refs/heads/master@{#16498}
Committed: https://chromium.googlesource.com/external/webrtc/+/273f31b85c1c87616ee6b8f2a540f2070b341416
Patch Set 1 #
Total comments: 3
Messages
Total messages: 20 (12 generated)
The CQ bit was checked by michaelt@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix for flaky RemoveOverheadFromBandwidth test. BUG=webrtc:6886 ========== to ========== Fix for flaky RemoveOverheadFromBandwidth test. BUG=webrtc:6886 ==========
michaelt@webrtc.org changed reviewers: + minyue@webrtc.org
Hi here a fix for the flaky test
https://codereview.webrtc.org/2685503002/diff/1/webrtc/video/video_send_strea... File webrtc/video/video_send_stream_tests.cc (right): https://codereview.webrtc.org/2685503002/diff/1/webrtc/video/video_send_strea... webrtc/video/video_send_stream_tests.cc:3224: EXPECT_LE(max_bitrate_bps_, 57760u); GE? https://codereview.webrtc.org/2685503002/diff/1/webrtc/video/video_send_strea... webrtc/video/video_send_stream_tests.cc:3224: EXPECT_LE(max_bitrate_bps_, 57760u); alternatively, we can change this to 57780u right?
lgtm https://codereview.webrtc.org/2685503002/diff/1/webrtc/video/video_send_strea... File webrtc/video/video_send_stream_tests.cc (right): https://codereview.webrtc.org/2685503002/diff/1/webrtc/video/video_send_strea... webrtc/video/video_send_stream_tests.cc:3224: EXPECT_LE(max_bitrate_bps_, 57760u); On 2017/02/07 13:04:00, minyue-webrtc wrote: > GE? forget this comment. I see the point. We used a wrong overhead 20, which made "max_bitrate_bps_ < 57780", we checked "max_bitrate_bps_>57760" and it can be correct anyway but not the right thing to test.
The CQ bit was checked by michaelt@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/13136)
michaelt@webrtc.org changed reviewers: + stefan@webrtc.org
lgtm
The CQ bit was checked by michaelt@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486565851185520, "parent_rev":
"87d11cdbca721c93cf3856026e1bce02c21abdff", "commit_rev":
"273f31b85c1c87616ee6b8f2a540f2070b341416"}
Message was sent while issue was closed.
Description was changed from ========== Fix for flaky RemoveOverheadFromBandwidth test. BUG=webrtc:6886 ========== to ========== Fix for flaky RemoveOverheadFromBandwidth test. BUG=webrtc:6886 Review-Url: https://codereview.webrtc.org/2685503002 Cr-Commit-Position: refs/heads/master@{#16498} Committed: https://chromium.googlesource.com/external/webrtc/+/273f31b85c1c87616ee6b8f2a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/273f31b85c1c87616ee6b8f2a... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
