Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2685183004: Update list of supported Android codecs based on field trial dynamically. (Closed)

Created:
3 years, 10 months ago by AlexG
Modified:
3 years, 10 months ago
Reviewers:
wzh, skvlad
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, magjed_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update list of supported Android codecs based on field trial dynamically. Currently filed trial value which controls H.264 high profile support is read once only when factory is created. If field trial value is changed for the next WebRTC call supported codec list need to be updated as well. BUG=b/34816463 Review-Url: https://codereview.webrtc.org/2685183004 Cr-Commit-Position: refs/heads/master@{#16543} Committed: https://chromium.googlesource.com/external/webrtc/+/abdc857967de12f61d394a38c72d23db382e2d22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -29 lines) Patch
M webrtc/sdk/android/src/jni/androidmediaencoder_jni.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc View 4 chunks +30 lines, -29 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
AlexG
PTAL
3 years, 10 months ago (2017-02-10 20:35:11 UTC) #2
wzh
lgtm
3 years, 10 months ago (2017-02-10 20:40:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2685183004/1
3 years, 10 months ago (2017-02-10 21:13:37 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-10 21:13:39 UTC) #7
skvlad
On 2017/02/10 20:40:10, wzh wrote: > lgtm lgtm
3 years, 10 months ago (2017-02-10 21:27:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2685183004/1
3 years, 10 months ago (2017-02-10 21:27:57 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 22:41:01 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/abdc857967de12f61d394a38c...

Powered by Google App Engine
This is Rietveld 408576698