Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2684683004: Make sure initial framedrop is off where quality scaling is off. (Closed)

Created:
3 years, 10 months ago by kthelgason
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make sure initial framedrop is off where quality scaling is off. BUG=chromium:689972, chromium:689915 Review-Url: https://codereview.webrtc.org/2684683004 Cr-Commit-Position: refs/heads/master@{#16602} Committed: https://chromium.googlesource.com/external/webrtc/+/ad9010c983631356bef481a2fc609b152a4e1410

Patch Set 1 #

Patch Set 2 : Add test for initial framedrop off where quality scaling off #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M webrtc/video/vie_encoder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 1 4 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
kthelgason
one line fix, please take a look.
3 years, 10 months ago (2017-02-09 08:43:24 UTC) #2
sprang_webrtc
Looks good, but could you add some more lines - like a case to cover ...
3 years, 10 months ago (2017-02-09 11:47:47 UTC) #3
kthelgason
On 2017/02/09 11:47:47, språng wrote: > Looks good, but could you add some more lines ...
3 years, 10 months ago (2017-02-10 08:20:14 UTC) #6
sprang_webrtc
lgtm Thanks!
3 years, 10 months ago (2017-02-10 09:44:16 UTC) #9
kthelgason
ping perkj :)
3 years, 10 months ago (2017-02-13 15:41:18 UTC) #10
perkj_webrtc
lgtm
3 years, 10 months ago (2017-02-13 17:37:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2684683004/20001
3 years, 10 months ago (2017-02-14 07:54:34 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/ad9010c983631356bef481a2fc609b152a4e1410
3 years, 10 months ago (2017-02-14 08:46:56 UTC) #16
nisse-webrtc
3 years, 10 months ago (2017-02-14 15:39:33 UTC) #17
Message was sent while issue was closed.
The new test appears to be a bit flaky. See, e.g., the win_dbg bot,
https://build.chromium.org/p/tryserver.webrtc/builders/win_dbg

Powered by Google App Engine
This is Rietveld 408576698