Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2684243002: Count FlexFEC packets in Call UMA stats. (Closed)

Created:
3 years, 10 months ago by brandtr
Modified:
3 years, 10 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman, nisse-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Count FlexFEC packets in Call UMA stats. BUG=webrtc:5654 Review-Url: https://codereview.webrtc.org/2684243002 Cr-Commit-Position: refs/heads/master@{#16768} Committed: https://chromium.googlesource.com/external/webrtc/+/798781299f07ac73e61ea10a8cfbeea243884084

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Patch Set 6 : Rebase. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/call/call.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 15 (4 generated)
brandtr
Fixing an old omission.
3 years, 10 months ago (2017-02-09 14:58:02 UTC) #2
brandtr
Rebase.
3 years, 10 months ago (2017-02-10 09:26:55 UTC) #3
brandtr
Rebase.
3 years, 10 months ago (2017-02-13 12:45:31 UTC) #4
brandtr
Rebase.
3 years, 10 months ago (2017-02-15 14:45:27 UTC) #5
brandtr
ping
3 years, 10 months ago (2017-02-16 15:07:41 UTC) #6
brandtr
Rebase.
3 years, 10 months ago (2017-02-20 12:47:26 UTC) #7
brandtr
Rebase.
3 years, 10 months ago (2017-02-21 12:01:15 UTC) #8
stefan-webrtc
lgtm https://codereview.webrtc.org/2684243002/diff/100001/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/2684243002/diff/100001/webrtc/call/call.cc#newcode1226 webrtc/call/call.cc:1226: received_bytes_per_second_counter_.Add(static_cast<int>(length)); Should this be a size_t counter?
3 years, 10 months ago (2017-02-21 12:06:37 UTC) #9
brandtr
https://codereview.webrtc.org/2684243002/diff/100001/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/2684243002/diff/100001/webrtc/call/call.cc#newcode1226 webrtc/call/call.cc:1226: received_bytes_per_second_counter_.Add(static_cast<int>(length)); On 2017/02/21 12:06:37, stefan-webrtc wrote: > Should this ...
3 years, 10 months ago (2017-02-22 08:27:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2684243002/100001
3 years, 10 months ago (2017-02-22 08:28:19 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 09:20:04 UTC) #15
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/798781299f07ac73e61ea10a8...

Powered by Google App Engine
This is Rietveld 408576698