Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2684223002:
Use std::unique_ptr in VideoProcessor. (Closed)
|
Created:
3 years, 10 months ago by åsapersson Modified:
3 years, 10 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionUse std::unique_ptr in VideoProcessor.
Add RTC_CHECKs for failures in VideoProcessor::Init.
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2684223002
Cr-Commit-Position: refs/heads/master@{#16526}
Committed: https://chromium.googlesource.com/external/webrtc/+/654d54c07385cf46f17693906aacb7716a2a3e14
Patch Set 1 #Patch Set 2 #
Total comments: 6
Patch Set 3 : address comments #
Total comments: 2
Messages
Total messages: 23 (15 generated)
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Use std::unique_ptr in VideoProcessor. Add RTC_CHECKs for failures in VideoProcessor::Init. BUG=webrtc:6634 ========== to ========== Use std::unique_ptr in VideoProcessor. Add RTC_CHECKs for failures in VideoProcessor::Init. BUG=webrtc:6634 ==========
asapersson@webrtc.org changed reviewers: + brandtr@webrtc.org
lgtm with nits. Nice with some cleanups! I had actually written my own TODO that this should be done in VideoProcessor :) https://codereview.webrtc.org/2684223002/diff/20001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/test/videoprocessor.h (right): https://codereview.webrtc.org/2684223002/diff/20001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/test/videoprocessor.h:206: uint8_t* last_successful_frame_buffer_; Make |last_successful_frame_buffer_| a std::unique_ptr<uint8_t[]>, while you're at it. https://codereview.webrtc.org/2684223002/diff/20001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/test/videoprocessor.h:238: VideoProcessorImpl* video_processor_; const? https://codereview.webrtc.org/2684223002/diff/20001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/test/videoprocessor.h:255: VideoProcessorImpl* video_processor_; const?
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
asapersson@webrtc.org changed reviewers: + sprang@webrtc.org
+sprang https://codereview.webrtc.org/2684223002/diff/20001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/test/videoprocessor.h (right): https://codereview.webrtc.org/2684223002/diff/20001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/test/videoprocessor.h:206: uint8_t* last_successful_frame_buffer_; On 2017/02/09 13:40:59, brandtr wrote: > Make |last_successful_frame_buffer_| a std::unique_ptr<uint8_t[]>, while you're > at it. Done. https://codereview.webrtc.org/2684223002/diff/20001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/test/videoprocessor.h:238: VideoProcessorImpl* video_processor_; On 2017/02/09 13:40:59, brandtr wrote: > const? Done. https://codereview.webrtc.org/2684223002/diff/20001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/test/videoprocessor.h:255: VideoProcessorImpl* video_processor_; On 2017/02/09 13:40:59, brandtr wrote: > const? Done.
lgtm, but please consider switching to a Buffer object. https://codereview.webrtc.org/2684223002/diff/40001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/test/videoprocessor.h (right): https://codereview.webrtc.org/2684223002/diff/40001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/test/videoprocessor.h:206: std::unique_ptr<uint8_t[]> last_successful_frame_buffer_; ..or maybe even an rtc::Buffer? Then we won't have to deal with manual memcpy and hoping that don't cause any buffer overflows...
lgtm, but please consider switching to a Buffer object. https://codereview.webrtc.org/2684223002/diff/40001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/test/videoprocessor.h (right): https://codereview.webrtc.org/2684223002/diff/40001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/test/videoprocessor.h:206: std::unique_ptr<uint8_t[]> last_successful_frame_buffer_; ..or maybe even an rtc::Buffer? Then we won't have to deal with manual memcpy and hoping that don't cause any buffer overflows...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.webrtc.org/2684223002/diff/40001/webrtc/modules/video_codi... File webrtc/modules/video_coding/codecs/test/videoprocessor.h (right): https://codereview.webrtc.org/2684223002/diff/40001/webrtc/modules/video_codi... webrtc/modules/video_coding/codecs/test/videoprocessor.h:206: std::unique_ptr<uint8_t[]> last_successful_frame_buffer_; On 2017/02/09 15:21:19, språng wrote: > ..or maybe even an rtc::Buffer? > Then we won't have to deal with manual memcpy and hoping that don't cause any > buffer overflows... Ok will look at it in a separate cl.
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org Link to the patchset: https://codereview.webrtc.org/2684223002/#ps40001 (title: "address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486714425869240,
"parent_rev": "c29988cb9a2b91885144ce7764f4b17d4226fcc3", "commit_rev":
"654d54c07385cf46f17693906aacb7716a2a3e14"}
Message was sent while issue was closed.
Description was changed from ========== Use std::unique_ptr in VideoProcessor. Add RTC_CHECKs for failures in VideoProcessor::Init. BUG=webrtc:6634 ========== to ========== Use std::unique_ptr in VideoProcessor. Add RTC_CHECKs for failures in VideoProcessor::Init. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2684223002 Cr-Commit-Position: refs/heads/master@{#16526} Committed: https://chromium.googlesource.com/external/webrtc/+/654d54c07385cf46f17693906... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/654d54c07385cf46f17693906... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
