Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2683583002: Add chromium-junit4 tag to instrumentation test AndroidManifests. (Closed)

Created:
3 years, 10 months ago by sakal
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add chromium-junit4 tag to instrumentation test AndroidManifests. This tag is supposed to be temporary and removed when all Chromium tests have been migrated to JUnit4. BUG=webrtc:7123, chromium:640116 NOTRY=True Review-Url: https://codereview.webrtc.org/2683583002 Cr-Commit-Position: refs/heads/master@{#16465} Committed: https://chromium.googlesource.com/external/webrtc/+/b99b5960e114933b1f0aef5c9b73cb85ba2aa876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M webrtc/examples/androidtests/AndroidManifest.xml View 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/sdk/android/instrumentationtests/AndroidManifest.xml View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
sakal
PTAL
3 years, 10 months ago (2017-02-07 10:09:38 UTC) #3
kjellander_webrtc
Thanks Sami! lgtm Seems like NOTRY=True is a good fit for this change.
3 years, 10 months ago (2017-02-07 10:37:47 UTC) #4
magjed_webrtc
lgtm
3 years, 10 months ago (2017-02-07 10:51:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2683583002/1
3 years, 10 months ago (2017-02-07 12:09:57 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 12:12:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b99b5960e114933b1f0aef5c9...

Powered by Google App Engine
This is Rietveld 408576698