Add support for swapping feeds in Android AppRTCMobile.

Add support for swapping feeds in Android AppRTCMobile.

BUG=webrtc:6937
Review-Url: https://codereview.webrtc.org/2682943006
Cr-Commit-Position: refs/heads/master@{#16582}
Committed: https://chromium.googlesource.com/external/webrtc/+/07a050f9952b30088d9ef527a01da7722424c01f

[sakal, 2017-02-10 08:38:03]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2017-02-10 08:38:04]

PTAL

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/BUILD.gn
File webrtc/examples/BUILD.gn (right):

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/BUILD.gn#...
webrtc/examples/BUILD.gn:67: android_manifest = "androidapp/AndroidManifest.xml"
This was required. Otherwise linter complains about supportsRtl tag.

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
File webrtc/examples/androidapp/AndroidManifest.xml (left):

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/AndroidManifest.xml:25: android:debuggable="true">
linter complained about this. I don't think it is needed so I just removed it.

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
File webrtc/examples/androidapp/AndroidManifest.xml (right):

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/AndroidManifest.xml:25: android:supportsRtl="false">
I don't think we support right-to-left locales? Linter wanted this to be
specified.

[sakal, 2017-02-10 12:21:21]

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
File webrtc/examples/androidapp/AndroidManifest.xml (left):

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/AndroidManifest.xml:25: android:debuggable="true">
On 2017/02/10 08:38:04, sakal wrote:
> linter complained about this. I don't think it is needed so I just removed it.

This was actually added recently so it is apparently needed for something. Let's
keep it.

[magjed_webrtc, 2017-02-10 13:23:38]

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
File webrtc/examples/androidapp/AndroidManifest.xml (left):

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/AndroidManifest.xml:25: android:debuggable="true">
On 2017/02/10 08:38:04, sakal wrote:
> linter complained about this. I don't think it is needed so I just removed it.

henrika@ wanted this in. We should probably keep it or talk to him about it.

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
File webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java
(right):

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java:182: private
boolean isSwappedFeeds;
Can you comment what it means when this is true vs false?

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java:189: 
nit: remove unnecessary empty line

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java:259:
setSwappedFeeds(true /* isSwappedFeeds */);
Add a comment why we start with local in fullscreen.

[sakal, 2017-02-10 14:05:36]

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
File webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java
(right):

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java:182: private
boolean isSwappedFeeds;
On 2017/02/10 13:23:38, magjed_webrtc wrote:
> Can you comment what it means when this is true vs false?

Done.

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java:189: 
On 2017/02/10 13:23:38, magjed_webrtc wrote:
> nit: remove unnecessary empty line

Done.

https://codereview.webrtc.org/2682943006/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java:259:
setSwappedFeeds(true /* isSwappedFeeds */);
On 2017/02/10 13:23:38, magjed_webrtc wrote:
> Add a comment why we start with local in fullscreen.

Done.

[magjed_webrtc, 2017-02-13 12:46:03]

lgtm

[sakal, 2017-02-13 12:46:50]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2017-02-13 12:46:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-13 13:58:27]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486990010259870,
"parent_rev": "f6ddbe77cbc54c8e5c99a1e0f833d9a25868d26e", "commit_rev":
"07a050f9952b30088d9ef527a01da7722424c01f"}

[commit-bot: I haz the power, 2017-02-13 13:58:30]

Description was changed from

==========
Add support for swapping feeds in Android AppRTCMobile.

BUG=webrtc:6937
==========

to

==========
Add support for swapping feeds in Android AppRTCMobile.

BUG=webrtc:6937

Review-Url: https://codereview.webrtc.org/2682943006
Cr-Commit-Position: refs/heads/master@{#16582}
Committed:
https://chromium.googlesource.com/external/webrtc/+/07a050f9952b30088d9ef527a...
==========

[commit-bot: I haz the power, 2017-02-13 13:58:31]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/07a050f9952b30088d9ef527a...