Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2682433005: Fix the Chrome crash caused by RtcEventLog (Closed)

Created:
3 years, 10 months ago by Zhi Huang
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix the Chrome crash caused by RtcEventLog Stop the RtcEventLog when the PeerConnection is closed so that Chrome will not crash because of creating too many threads. BUG=chromium:687553 Review-Url: https://codereview.webrtc.org/2682433005 Cr-Commit-Position: refs/heads/master@{#16482} Committed: https://chromium.googlesource.com/external/webrtc/+/7798501d7a20129d45889aac6854f00a55f20445

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M webrtc/pc/peerconnection.cc View 1 2 chunks +7 lines, -1 line 0 comments Download
M webrtc/pc/peerconnectioninterface_unittest.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Taylor Brandstetter
lgtm
3 years, 10 months ago (2017-02-07 21:14:17 UTC) #6
Taylor Brandstetter
https://codereview.webrtc.org/2682433005/diff/1/webrtc/pc/peerconnection.cc File webrtc/pc/peerconnection.cc (right): https://codereview.webrtc.org/2682433005/diff/1/webrtc/pc/peerconnection.cc#newcode2578 webrtc/pc/peerconnection.cc:2578: event_log_->StopLogging(); Actually, we should check if event_log_ is null ...
3 years, 10 months ago (2017-02-07 21:15:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2682433005/20001
3 years, 10 months ago (2017-02-07 23:12:34 UTC) #14
Taylor Brandstetter
lgtm for the updated patchset
3 years, 10 months ago (2017-02-07 23:15:11 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 23:45:22 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/7798501d7a20129d45889aac6...

Powered by Google App Engine
This is Rietveld 408576698