Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2682073003: Revert Make the new jitter buffer the default jitter buffer. (Closed)

Created:
3 years, 10 months ago by stefan-webrtc
Modified:
3 years, 10 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert Make the new jitter buffer the default jitter buffer. Speculative revert of https://codereview.chromium.org/2656983002/ to see if it fixes a downstream bug. BUG=webrtc:5514 Review-Url: https://codereview.webrtc.org/2682073003 Cr-Commit-Position: refs/heads/master@{#16492} Committed: https://chromium.googlesource.com/external/webrtc/+/e525d6aba634b8442a0b9c247a89a6060d225ca3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -315 lines) Patch
M webrtc/modules/video_coding/frame_buffer2.h View 4 chunks +11 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.cc View 5 chunks +30 lines, -24 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2_unittest.cc View 6 chunks +1 line, -61 lines 0 comments Download
M webrtc/modules/video_coding/include/video_coding_defines.h View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/timing.h View 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver.cc View 2 chunks +22 lines, -5 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 7 chunks +10 lines, -21 lines 0 comments Download
M webrtc/video/receive_statistics_proxy.cc View 10 chunks +20 lines, -70 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 2 chunks +8 lines, -11 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.h View 3 chunks +3 lines, -0 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 6 chunks +74 lines, -55 lines 0 comments Download
M webrtc/video/rtp_stream_receiver_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/video/video_receive_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 6 chunks +40 lines, -26 lines 0 comments Download
M webrtc/video/video_stream_decoder.h View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/video/video_stream_decoder.cc View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
stefan-webrtc
3 years, 10 months ago (2017-02-08 11:51:36 UTC) #2
nisse-webrtc
lgtm
3 years, 10 months ago (2017-02-08 11:57:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2682073003/1
3 years, 10 months ago (2017-02-08 11:57:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/22518)
3 years, 10 months ago (2017-02-08 12:13:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2682073003/1
3 years, 10 months ago (2017-02-08 12:48:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/e525d6aba634b8442a0b9c247a89a6060d225ca3
3 years, 10 months ago (2017-02-08 13:25:49 UTC) #12
philipel
3 years, 10 months ago (2017-02-20 14:19:56 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2704183002/ by philipel@webrtc.org.

The reason for reverting is: Fix here:
https://codereview.chromium.org/2708593003.

Powered by Google App Engine
This is Rietveld 408576698