Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2681733002: Remove workaround for bug 6986 (Closed)

Created:
3 years, 10 months ago by kwiberg-webrtc
Modified:
3 years, 9 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove workaround for bug 6986 BUG=webrtc:6986 Review-Url: https://codereview.webrtc.org/2681733002 Cr-Commit-Position: refs/heads/master@{#16933} Committed: https://chromium.googlesource.com/external/webrtc/+/09f090c40e7037ea64b57daaa8f96d0e04bd257c

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M webrtc/voice_engine/channel.cc View 1 2 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
kwiberg-webrtc
We should be able to land this one now that https://codereview.chromium.org/2710483002/ has landed.
3 years, 10 months ago (2017-02-22 12:13:26 UTC) #4
ossu
Not sure I understand the solution in the related CL, but if it works, then ...
3 years, 10 months ago (2017-02-22 12:20:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2681733002/40001
3 years, 9 months ago (2017-03-01 09:54:37 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 09:57:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/09f090c40e7037ea64b57daaa...

Powered by Google App Engine
This is Rietveld 408576698