Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2681403002: Merge to M57: Only set certificate on DTLS transport if fingerprint is found in SDP. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/branch-heads/57
Project:
webrtc
Visibility:
Public.

Description

Merge to M57: Only set certificate on DTLS transport if fingerprint is found in SDP. This is used for fallback from DTLS to SDES encryption, which we probably still want to support. Setting a certificate puts the DTLS transport in a "DTLS enabled" mode, so it should be delayed until SDP with "a=fingerprint" is set. BUG=chromium:690069 NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2681403002 Cr-Commit-Position: refs/branch-heads/57@{#4} Cr-Branched-From: e5cbc2019003dbb40e03811d7607feb95757a4ec-refs/heads/master@{#16123} Committed: https://chromium.googlesource.com/external/webrtc/+/76ad439d6c00e2f3ee62e417390541616522a35e

Patch Set 1 #

Patch Set 2 : Changing upstream branch to m57 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -16 lines) Patch
M webrtc/api/peerconnectioninterface_unittest.cc View 4 chunks +48 lines, -1 line 0 comments Download
M webrtc/api/test/fakertccertificategenerator.h View 3 chunks +4 lines, -0 lines 0 comments Download
M webrtc/base/sslfingerprint.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/base/sslfingerprint.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 1 chunk +14 lines, -2 lines 0 comments Download
M webrtc/p2p/base/jseptransport.cc View 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/p2p/base/transportcontroller.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (6 generated)
pthatcher1
lgtm
3 years, 10 months ago (2017-02-09 21:58:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2681403002/20001
3 years, 10 months ago (2017-02-09 22:09:31 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 22:09:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/76ad439d6c00e2f3ee62e4173...

Powered by Google App Engine
This is Rietveld 408576698