Split LastFir status out of RTCPReceiver::ReceiveInfo

Split LastFir status out of RTCPReceiver::ReceiveInfo

This a pre-step for improving perfomance of the RTCPReceiver
- rest of the ReceiveInfo is tmmbr related and
can be handled only when tmmbr is explicitly enabled.

BUG=webrtc:5565
Review-Url: https://codereview.webrtc.org/2681003003
Cr-Commit-Position: refs/heads/master@{#16667}
Committed: https://chromium.googlesource.com/external/webrtc/+/efa966b608dba57bedee0bb65b23c66da407b2c0

[danilchap, 2017-02-08 12:34:15]

Description was changed from

==========
Split LastFir status out of RTCPReceiver::ReceiveInfo

This a pre-step for improving perfomance of the RTCPReceiver
- rest of the ReceiveInfo is tmmbr related and
can be handled only when tmmbr is explicetly enabled.

BUG=webrtc:5565
==========

to

==========
Split LastFir status out of RTCPReceiver::ReceiveInfo

This a pre-step for improving perfomance of the RTCPReceiver
- rest of the ReceiveInfo is tmmbr related and
can be handled only when tmmbr is explicitly enabled.

BUG=webrtc:5565
==========

[danilchap, 2017-02-08 12:34:15]

danilchap@webrtc.org changed reviewers:
+ stefan@webrtc.org

[danilchap, 2017-02-08 12:34:32]

The CQ bit was checked by danilchap@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 12:34:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-08 13:23:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 13:23:11]

Dry run: This issue passed the CQ dry run.

[danilchap, 2017-02-09 15:08:02]

danilchap@webrtc.org changed reviewers:
+ philipel@webrtc.org
- stefan@webrtc.org

[danilchap, 2017-02-10 09:51:50]

More cleaning of (less visible) tmmbr related code from RtcpReceiver,
ptal

[philipel, 2017-02-15 09:58:23]

I can only give stylistic comments since I don't know much about either the
RTCPReceiver or what the long term goal with this change is.

https://codereview.webrtc.org/2681003003/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2681003003/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:898: if (!inserted.second) {  //
There was entry already.
'There was already an entry.' or 'Last fir already inserted for this ssrc'

[danilchap, 2017-02-15 10:20:49]

no plans for anything complicated, so stylistic comment are good.

https://codereview.webrtc.org/2681003003/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc (right):

https://codereview.webrtc.org/2681003003/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:898: if (!inserted.second) {  //
There was entry already.
On 2017/02/15 09:58:23, philipel wrote:
> 'There was already an entry.' or 'Last fir already inserted for this ssrc'

Done.

[danilchap, 2017-02-16 15:38:05]

danilchap@webrtc.org changed reviewers:
+ nisse@webrtc.org
- philipel@webrtc.org

[danilchap, 2017-02-16 15:38:06]

Nisse, are you comfortable reviewing non-functional changes in rtcp_receiver?

[nisse-webrtc, 2017-02-17 09:09:05]

On 2017/02/16 15:38:06, danilchap wrote:
> Nisse, are you comfortable reviewing non-functional changes in rtcp_receiver?

Sure, if you at the same time can educate me on what the code is doing.... I'm 
blissfully ignorant on what "fir" and "tmmbr" means here.

[nisse-webrtc, 2017-02-17 11:39:00]

lgtm

[danilchap, 2017-02-17 12:24:37]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2017-02-17 12:24:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-17 14:23:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487334277528730,
"parent_rev": "642943baead06cf639400470fb537987aec11f9d", "commit_rev":
"efa966b608dba57bedee0bb65b23c66da407b2c0"}

[commit-bot: I haz the power, 2017-02-17 14:23:20]

Description was changed from

==========
Split LastFir status out of RTCPReceiver::ReceiveInfo

This a pre-step for improving perfomance of the RTCPReceiver
- rest of the ReceiveInfo is tmmbr related and
can be handled only when tmmbr is explicitly enabled.

BUG=webrtc:5565
==========

to

==========
Split LastFir status out of RTCPReceiver::ReceiveInfo

This a pre-step for improving perfomance of the RTCPReceiver
- rest of the ReceiveInfo is tmmbr related and
can be handled only when tmmbr is explicitly enabled.

BUG=webrtc:5565

Review-Url: https://codereview.webrtc.org/2681003003
Cr-Commit-Position: refs/heads/master@{#16667}
Committed:
https://chromium.googlesource.com/external/webrtc/+/efa966b608dba57bedee0bb65...
==========

[commit-bot: I haz the power, 2017-02-17 14:23:21]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/efa966b608dba57bedee0bb65...