Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2680973005: Fix for left shift of potentially negative value. (Closed)

Created:
3 years, 10 months ago by ivoc
Modified:
3 years, 10 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix for left shift of potentially negative value. Left shifting of negative integers is undefined behavior, and should be prevented. This CL fixes one such instance in the Levinson Durbin function. BUG=chromium:681377 Review-Url: https://codereview.webrtc.org/2680973005 Cr-Commit-Position: refs/heads/master@{#16507} Committed: https://chromium.googlesource.com/external/webrtc/+/a48e1b6bc3d26dfc70748f05112617e8fddb32fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/common_audio/signal_processing/levinson_durbin.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
ivoc
Hi Karl, PTAL at another fuzzer fix. This one is very similar to the last ...
3 years, 10 months ago (2017-02-08 16:19:50 UTC) #3
kwiberg-webrtc
lgtm
3 years, 10 months ago (2017-02-09 05:12:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2680973005/1
3 years, 10 months ago (2017-02-09 09:45:04 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 11:06:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a48e1b6bc3d26dfc70748f051...

Powered by Google App Engine
This is Rietveld 408576698