Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2680743003: Revert of Roll chromium_revision 496a750d38..70957b2671 (447619:448581) (Closed)

Created:
3 years, 10 months ago by kjellander_webrtc
Modified:
3 years, 10 months ago
Reviewers:
buildbot
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Roll chromium_revision 496a750d38..70957b2671 (447619:448581) (patchset #1 id:1 of https://codereview.webrtc.org/2683593002/ ) Reason for revert: Breaks internal projects. Original issue's description: > Roll chromium_revision 496a750d38..70957b2671 (447619:448581) > > Change log: https://chromium.googlesource.com/chromium/src/+log/496a750d38..70957b2671 > Full diff: https://chromium.googlesource.com/chromium/src/+/496a750d38..70957b2671 > > Changed dependencies: > * src/base: https://chromium.googlesource.com/chromium/src/base/+log/32f2a4543f..3a1e5145d5 > * src/build: https://chromium.googlesource.com/chromium/src/build/+log/337c73855e..a5b79d9869 > * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/6b87d69c72..533d4812cc > * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/04c1f97a2d..908af2e604 > * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/c9a58f7ae6..8694363380 > * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/358baeb9a4..3f2611a98f > * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a801abb6bc..df67b47911 > * src/third_party/gtest-parallel: https://chromium.googlesource.com/external/webrtc/deps/third_party/gtest-parallel/+log/8768563f5c..e281b59a8e > * src/third_party/libFuzzer/src: https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer.git/+log/78ee52d0c6..64bdf91585 > * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/d4ba547dba..9491f0f1c7 > DEPS diff: https://chromium.googlesource.com/chromium/src/+/496a750d38..70957b2671/DEPS > > No update to Clang. > > TBR= > BUG=None > > Review-Url: https://codereview.webrtc.org/2683593002 > Cr-Commit-Position: refs/heads/master@{#16466} > Committed: https://chromium.googlesource.com/external/webrtc/+/040f5cc5d740df43c3e5ec21f5c5a21e9e695f03 TBR=buildbot@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2680743003 Cr-Commit-Position: refs/heads/master@{#16468} Committed: https://chromium.googlesource.com/external/webrtc/+/f81be0a83bed6516f66980378bd8bb1207033709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M DEPS View 6 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_webrtc
Created Revert of Roll chromium_revision 496a750d38..70957b2671 (447619:448581)
3 years, 10 months ago (2017-02-07 13:47:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2680743003/1
3 years, 10 months ago (2017-02-07 13:48:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/f81be0a83bed6516f66980378bd8bb1207033709
3 years, 10 months ago (2017-02-07 13:48:16 UTC) #6
kjellander_webrtc
3 years, 10 months ago (2017-02-08 09:26:49 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2687643003/ by kjellander@webrtc.org.

The reason for reverting is: The downstream problem should be fixed now..

Powered by Google App Engine
This is Rietveld 408576698