Use fake clock in some more networks tests.

Use fake clock in some more networks tests.

BUG=b/34822484

Review-Url: https://codereview.webrtc.org/2680233002
Cr-Commit-Position: refs/heads/master@{#16502}
Committed: https://chromium.googlesource.com/external/webrtc/+/1749bc372e93bf9f6362f8a739ec08daeefceef5

[pthatcher1, 2017-02-08 00:13:32]

The CQ bit was checked by pthatcher@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 00:13:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[pthatcher1, 2017-02-08 00:14:20]

Description was changed from

==========
Use fake clock in some more networks tests.

BUG=b/34822484
==========

to

==========
Use fake clock in some more networks tests.

BUG=b/34822484
==========

[pthatcher1, 2017-02-08 00:14:20]

pthatcher@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, skvlad@webrtc.org

[commit-bot: I haz the power, 2017-02-08 00:15:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:15:05]

Dry run: Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/21236)

[Taylor Brandstetter, 2017-02-08 01:23:59]

https://codereview.webrtc.org/2680233002/diff/1/webrtc/base/messagequeue.cc
File webrtc/base/messagequeue.cc (right):

https://codereview.webrtc.org/2680233002/diff/1/webrtc/base/messagequeue.cc#n...
webrtc/base/messagequeue.cc:253: }
nit: newline

https://codereview.webrtc.org/2680233002/diff/1/webrtc/p2p/base/stunport_unit...
File webrtc/p2p/base/stunport_unittest.cc (right):

https://codereview.webrtc.org/2680233002/diff/1/webrtc/p2p/base/stunport_unit...
webrtc/p2p/base/stunport_unittest.cc:245: EXPECT_EQ_SIMULATED_WAIT(1U,
port()->Candidates().size(), 500, fake_clock());
This should do SIMULATED_WAIT(false, 1000, fake_clock()) followed by EXPECT_EQ

https://codereview.webrtc.org/2680233002/diff/1/webrtc/p2p/client/basicportal...
File webrtc/p2p/client/basicportallocator_unittest.cc (right):

https://codereview.webrtc.org/2680233002/diff/1/webrtc/p2p/client/basicportal...
webrtc/p2p/client/basicportallocator_unittest.cc:1146:
EXPECT_TRUE(candidate_allocation_done_);
Don't need this additional EXPECT_TRUE

https://codereview.webrtc.org/2680233002/diff/1/webrtc/p2p/client/basicportal...
webrtc/p2p/client/basicportallocator_unittest.cc:1224:
EXPECT_TRUE_SIMULATED_WAIT(candidate_allocation_done_, 6500, fake_clock);
Does this pass? I think my comment about 6.5 seconds was a typo. Also, could you
leave a comment mentioning where the time comes from?

https://codereview.webrtc.org/2680233002/diff/1/webrtc/p2p/client/basicportal...
webrtc/p2p/client/basicportallocator_unittest.cc:1786:
fake_clock.AdvanceTime(rtc::TimeDelta::FromMilliseconds(1000));
To be safe I'd prefer SIMULATED_WAIT(false, 1000, fake_clock()).

[pthatcher1, 2017-02-08 08:52:24]

https://codereview.webrtc.org/2680233002/diff/1/webrtc/base/messagequeue.cc
File webrtc/base/messagequeue.cc (right):

https://codereview.webrtc.org/2680233002/diff/1/webrtc/base/messagequeue.cc#n...
webrtc/base/messagequeue.cc:253: }
On 2017/02/08 01:23:58, Taylor Brandstetter wrote:
> nit: newline

Done.

https://codereview.webrtc.org/2680233002/diff/1/webrtc/p2p/base/stunport_unit...
File webrtc/p2p/base/stunport_unittest.cc (right):

https://codereview.webrtc.org/2680233002/diff/1/webrtc/p2p/base/stunport_unit...
webrtc/p2p/base/stunport_unittest.cc:245: EXPECT_EQ_SIMULATED_WAIT(1U,
port()->Candidates().size(), 500, fake_clock());
On 2017/02/08 01:23:59, Taylor Brandstetter wrote:
> This should do SIMULATED_WAIT(false, 1000, fake_clock()) followed by EXPECT_EQ

Done.

https://codereview.webrtc.org/2680233002/diff/1/webrtc/p2p/client/basicportal...
File webrtc/p2p/client/basicportallocator_unittest.cc (right):

https://codereview.webrtc.org/2680233002/diff/1/webrtc/p2p/client/basicportal...
webrtc/p2p/client/basicportallocator_unittest.cc:1224:
EXPECT_TRUE_SIMULATED_WAIT(candidate_allocation_done_, 6500, fake_clock);
On 2017/02/08 01:23:59, Taylor Brandstetter wrote:
> Does this pass? I think my comment about 6.5 seconds was a typo. Also, could
you
> leave a comment mentioning where the time comes from?

Yes, it passes.  I added a comment explaining why and double-checked that 5500
does not pass.  Your comment was not a typo.

https://codereview.webrtc.org/2680233002/diff/1/webrtc/p2p/client/basicportal...
webrtc/p2p/client/basicportallocator_unittest.cc:1786:
fake_clock.AdvanceTime(rtc::TimeDelta::FromMilliseconds(1000));
On 2017/02/08 01:23:59, Taylor Brandstetter wrote:
> To be safe I'd prefer SIMULATED_WAIT(false, 1000, fake_clock()).

Done.

[Taylor Brandstetter, 2017-02-08 09:21:26]

lgtm, and thanks for working on this

https://codereview.webrtc.org/2680233002/diff/20001/webrtc/p2p/client/basicpo...
File webrtc/p2p/client/basicportallocator_unittest.cc (right):

https://codereview.webrtc.org/2680233002/diff/20001/webrtc/p2p/client/basicpo...
webrtc/p2p/client/basicportallocator_unittest.cc:1225: // only need 6.5 more
seconds.
Well now I feel dumb

[pthatcher1, 2017-02-08 09:23:02]

The CQ bit was checked by pthatcher@webrtc.org

[commit-bot: I haz the power, 2017-02-08 09:23:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-08 09:24:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 09:24:40]

Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/17240)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/21254)

[pthatcher1, 2017-02-08 09:46:35]

The CQ bit was checked by pthatcher@webrtc.org

[pthatcher1, 2017-02-08 09:46:35]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2680233002/#ps40001 (title:
"Use the real clock for 2 tests.")

[commit-bot: I haz the power, 2017-02-08 09:46:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-08 09:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 09:48:16]

Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/17241)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/22504)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/21255)

[pthatcher1, 2017-02-08 10:24:45]

The CQ bit was checked by pthatcher@webrtc.org

[pthatcher1, 2017-02-08 10:24:46]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2680233002/#ps60001 (title:
"Use the real clock for yet another test.")

[commit-bot: I haz the power, 2017-02-08 10:24:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-08 10:26:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 10:26:23]

Try jobs failed on following builders:
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/17243)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/17069)

[pthatcher1, 2017-02-08 19:38:58]

The CQ bit was checked by pthatcher@webrtc.org

[pthatcher1, 2017-02-08 19:38:59]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2680233002/#ps80001 (title:
"Merge with master")

[commit-bot: I haz the power, 2017-02-08 19:39:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[pthatcher1, 2017-02-08 19:46:58]

The CQ bit was unchecked by pthatcher@webrtc.org

[pthatcher1, 2017-02-08 20:09:57]

The CQ bit was checked by pthatcher@webrtc.org

[pthatcher1, 2017-02-08 20:09:57]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2680233002/#ps100001 (title:
"Use a different fake clock thing.")

[commit-bot: I haz the power, 2017-02-08 20:10:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-08 21:18:01]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1486584597518300,
"parent_rev": "4da058c0ddfee9041c04461dc50d15c766a8bcd4", "commit_rev":
"1749bc372e93bf9f6362f8a739ec08daeefceef5"}

[commit-bot: I haz the power, 2017-02-08 21:18:04]

Description was changed from

==========
Use fake clock in some more networks tests.

BUG=b/34822484
==========

to

==========
Use fake clock in some more networks tests.

BUG=b/34822484

Review-Url: https://codereview.webrtc.org/2680233002
Cr-Commit-Position: refs/heads/master@{#16502}
Committed:
https://chromium.googlesource.com/external/webrtc/+/1749bc372e93bf9f6362f8a73...
==========

[commit-bot: I haz the power, 2017-02-08 21:18:05]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/1749bc372e93bf9f6362f8a73...