Remove rtcp_utility as mostly unused.

Remove rtcp_utility as mostly unused.
Since the only used class is RTCPUtilitiy::NackStats,
rename it to RtcpNackStats and move it into dedicated file.

BUG=webrtc:5565
Review-Url: https://codereview.webrtc.org/2680183004
Cr-Commit-Position: refs/heads/master@{#16515}
Committed: https://chromium.googlesource.com/external/webrtc/+/8443238e268dfb708fd1115ef485f7e17515f449

[danilchap, 2017-02-09 09:28:15]

The CQ bit was checked by danilchap@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 09:28:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-09 10:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 10:57:14]

Dry run: This issue passed the CQ dry run.

[danilchap, 2017-02-09 12:01:32]

danilchap@webrtc.org changed reviewers:
+ nisse@webrtc.org

[nisse-webrtc, 2017-02-09 12:16:53]

https://codereview.webrtc.org/2680183004/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/nack_stats.h (right):

https://codereview.webrtc.org/2680183004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/nack_stats.h:18: class NackStats {
Rename to RtpNackStats or RtcpNackStats (and rename the file too), now when it's
no longer under the RTPUtility namespace.

https://codereview.webrtc.org/2680183004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/nack_stats.h:36: uint32_t unique_requests_;
You could consider using a wider type than uint32_t. But uint32_t is consistent
with use in RtcpPacketTypeCounter (in common_types.h).

[danilchap, 2017-02-09 12:28:17]

https://codereview.webrtc.org/2680183004/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/nack_stats.h (right):

https://codereview.webrtc.org/2680183004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/nack_stats.h:18: class NackStats {
On 2017/02/09 12:16:52, nisse-webrtc wrote:
> Rename to RtpNackStats or RtcpNackStats (and rename the file too), now when
it's
> no longer under the RTPUtility namespace.

Done.

https://codereview.webrtc.org/2680183004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/nack_stats.h:36: uint32_t unique_requests_;
On 2017/02/09 12:16:52, nisse-webrtc wrote:
> You could consider using a wider type than uint32_t. But uint32_t is
consistent
> with use in RtcpPacketTypeCounter (in common_types.h).

I consciously left the implementation of this class unchanged since it is not
subject of this CL. (otherwise would change this counters to size_t to follow
chromium guidelines)

[nisse-webrtc, 2017-02-09 12:34:05]

lgtm. Please update cl description with the class renaming before landing.

Great to see this go.

https://codereview.webrtc.org/2680183004/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/nack_stats.h (right):

https://codereview.webrtc.org/2680183004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/nack_stats.h:36: uint32_t unique_requests_;
On 2017/02/09 12:28:16, danilchap wrote:
> On 2017/02/09 12:16:52, nisse-webrtc wrote:
> > You could consider using a wider type than uint32_t. But uint32_t is
> consistent
> > with use in RtcpPacketTypeCounter (in common_types.h).
> 
> I consciously left the implementation of this class unchanged since it is not
> subject of this CL. (otherwise would change this counters to size_t to follow
> chromium guidelines)

Acknowledged.

[danilchap, 2017-02-09 12:43:08]

Description was changed from

==========
Remove rtcp_utility as mostly unused.
Since the only used class is NackStats, move it into dedicated file.

BUG=webrtc:5565
==========

to

==========
Remove rtcp_utility as mostly unused.
Since the only used class is RTCPUtilitiy::NackStats,
rename it to RtcpNackStats and move it into dedicated file.

BUG=webrtc:5565
==========

[danilchap, 2017-02-09 12:44:16]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2017-02-09 12:44:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-09 13:21:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486644256450920,
"parent_rev": "9def800b7055de678bd5bf464f06194bb94ccd2a", "commit_rev":
"8443238e268dfb708fd1115ef485f7e17515f449"}

[commit-bot: I haz the power, 2017-02-09 13:21:44]

Description was changed from

==========
Remove rtcp_utility as mostly unused.
Since the only used class is RTCPUtilitiy::NackStats,
rename it to RtcpNackStats and move it into dedicated file.

BUG=webrtc:5565
==========

to

==========
Remove rtcp_utility as mostly unused.
Since the only used class is RTCPUtilitiy::NackStats,
rename it to RtcpNackStats and move it into dedicated file.

BUG=webrtc:5565

Review-Url: https://codereview.webrtc.org/2680183004
Cr-Commit-Position: refs/heads/master@{#16515}
Committed:
https://chromium.googlesource.com/external/webrtc/+/8443238e268dfb708fd1115ef...
==========

[commit-bot: I haz the power, 2017-02-09 13:21:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/8443238e268dfb708fd1115ef...