Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2680023005: Clarifying error messages in ParseIceServerUrl for invalid transport parameters. (Closed)

Created:
3 years, 10 months ago by Zach Stein
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clarifying error messages in ParseIceServerUrl for invalid transport parameters. BUG=webrtc:6662 Review-Url: https://codereview.webrtc.org/2680023005 Cr-Commit-Position: refs/heads/master@{#16481} Committed: https://chromium.googlesource.com/external/webrtc/+/9dd77baca440ed3053eeca5f84ec2e4810401d9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M webrtc/pc/peerconnection.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M webrtc/pc/peerconnection_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
Taylor Brandstetter
lgtm
3 years, 10 months ago (2017-02-07 21:49:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2680023005/1
3 years, 10 months ago (2017-02-07 23:07:14 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 23:09:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/9dd77baca440ed3053eeca5f8...

Powered by Google App Engine
This is Rietveld 408576698