Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2679913002: Remove use of selectors matching Apple private API names. (Closed)

Created:
3 years, 10 months ago by kthelgason
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc antoniotuzzi_gmail.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove use of selectors matching Apple private API names. This was causing some apps that include WebRTC to be rejected from the app store. BUG=webrtc:6382 Review-Url: https://codereview.webrtc.org/2679913002 Cr-Commit-Position: refs/heads/master@{#16462} Committed: https://chromium.googlesource.com/external/webrtc/+/1634e160426df926e14cf9f1e5346d2a1dc9c909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M webrtc/modules/audio_device/ios/objc/RTCAudioSession.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/ios/objc/RTCAudioSessionDelegateAdapter.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/ios/objc/RTCAudioSessionTest.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kthelgason
PTAL
3 years, 10 months ago (2017-02-07 09:10:19 UTC) #2
magjed_webrtc
lgtm
3 years, 10 months ago (2017-02-07 09:16:10 UTC) #3
henrika_webrtc
lgtm
3 years, 10 months ago (2017-02-07 09:20:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2679913002/1
3 years, 10 months ago (2017-02-07 09:47:25 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 10:48:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1634e160426df926e14cf9f1e...

Powered by Google App Engine
This is Rietveld 408576698