Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2679143002: Removed duplicated annotation in webrtc/examples/androidtests/AndroidManifest.xml (Closed)

Created:
3 years, 10 months ago by mandermo
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed duplicated annotation in webrtc/examples/androidtests/AndroidManifest.xml BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2679143002 Cr-Commit-Position: refs/heads/master@{#17787} Committed: https://chromium.googlesource.com/external/webrtc/+/76ec9d7364ac223ac44c55c7267648245f183025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M webrtc/examples/androidtests/AndroidManifest.xml View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
mandermo
One of the annotation also used permissions instead of permission in the name.
3 years, 10 months ago (2017-02-07 15:10:38 UTC) #2
kjellander_webrtc
Ah, now I see why it was duplicated. A typo :) lgtm I also added ...
3 years, 10 months ago (2017-02-07 17:40:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2679143002/1
3 years, 8 months ago (2017-04-19 20:14:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16264)
3 years, 8 months ago (2017-04-19 20:19:47 UTC) #12
kjellander_webrtc
I found this old CL laying around. Let's submit it. +magjed@webrtc.org for owners
3 years, 8 months ago (2017-04-19 20:23:09 UTC) #14
magjed_webrtc
lgtm
3 years, 8 months ago (2017-04-20 12:29:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2679143002/1
3 years, 8 months ago (2017-04-20 12:29:21 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 12:31:36 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/76ec9d7364ac223ac44c55c72...

Powered by Google App Engine
This is Rietveld 408576698