|
|
DescriptionRemoved duplicated annotation in webrtc/examples/androidtests/AndroidManifest.xml
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2679143002
Cr-Commit-Position: refs/heads/master@{#17787}
Committed: https://chromium.googlesource.com/external/webrtc/+/76ec9d7364ac223ac44c55c7267648245f183025
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
mandermo@webrtc.org changed reviewers: + kjellander@webrtc.org
One of the annotation also used permissions instead of permission in the name.
The CQ bit was checked by mandermo@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Removed duplicated annotation in webrtc/examples/androidtests/AndroidManifest.xml BUG=None ========== to ========== Removed duplicated annotation in webrtc/examples/androidtests/AndroidManifest.xml BUG=None NOTRY=True ==========
Ah, now I see why it was duplicated. A typo :) lgtm I also added NOTRY=True
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16264)
kjellander@webrtc.org changed reviewers: + magjed@webrtc.org
I found this old CL laying around. Let's submit it. +magjed@webrtc.org for owners
The CQ bit was checked by magjed@webrtc.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1492691353922690, "parent_rev": "b99baf8280a9a98e6d5e001f86692b8fd44a63cb", "commit_rev": "76ec9d7364ac223ac44c55c7267648245f183025"}
Message was sent while issue was closed.
Description was changed from ========== Removed duplicated annotation in webrtc/examples/androidtests/AndroidManifest.xml BUG=None NOTRY=True ========== to ========== Removed duplicated annotation in webrtc/examples/androidtests/AndroidManifest.xml BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2679143002 Cr-Commit-Position: refs/heads/master@{#17787} Committed: https://chromium.googlesource.com/external/webrtc/+/76ec9d7364ac223ac44c55c72... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/76ec9d7364ac223ac44c55c72... |