Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2679103007: Allow residual echo detector to be enabled/disabled using AudioOptions, and no longer disable it on… (Closed)

Created:
3 years, 10 months ago by ivoc
Modified:
3 years, 10 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Allow residual echo detector to be enabled/disabled using AudioOptions, and no longer disable it on mobile platforms. BUG=webrtc:7136 Review-Url: https://codereview.webrtc.org/2679103007 Cr-Commit-Position: refs/heads/master@{#16531} Committed: https://chromium.googlesource.com/external/webrtc/+/4ca18696c5a3812d044b0a070229825ecab409b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M webrtc/media/engine/webrtcvoiceengine.cc View 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ivoc
Fredrik, PTAL at this small CL to allow the echo detector to be enabled/disabled using ...
3 years, 10 months ago (2017-02-09 14:31:57 UTC) #2
the sun
Ah, it's default enabled anyway in AudioProcessing::Config::ResidualEchoDetector. lgtm
3 years, 10 months ago (2017-02-10 11:35:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2679103007/1
3 years, 10 months ago (2017-02-10 11:58:01 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 13:11:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/4ca18696c5a3812d044b0a070...

Powered by Google App Engine
This is Rietveld 408576698