Delete VideoReceiveStream::Config::pre_render_callback.

Delete VideoReceiveStream::Config::pre_render_callback.

Also delete the class I420FrameCallback.

BUG=webrtc:7124
Review-Url: https://codereview.webrtc.org/2678343002
Cr-Commit-Position: refs/heads/master@{#16478}
Committed: https://chromium.googlesource.com/external/webrtc/+/76bc8e858ff288449163c97aa66928f2eecdfd28

[nisse-webrtc, 2017-02-07 08:55:08]

nisse@webrtc.org changed reviewers:
+ sprang@webrtc.org, tommi@webrtc.org

[nisse-webrtc, 2017-02-07 08:55:08]

PTAL.

This deletes pre_render_callback (from the public context struct). Hopefully our
own use en end to end tests was the only.

Who's familiar with these parts of the end to end tests? In the git logs, it
seems pbos was involved in writing the FrameCallbacks which are now merged with
the corresponding renderer callback.

[sprang_webrtc, 2017-02-07 09:52:03]

I think the purpose of this callback was to be able to do postprocessing of
video, but as this doesn't seem to have materialized, and can just as easily be
done with the video sink interface, I think removing it makes a lot of sense.

lgtm

https://codereview.webrtc.org/2678343002/diff/1/webrtc/video/end_to_end_tests.cc
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2678343002/diff/1/webrtc/video/end_to_end_tests...
webrtc/video/end_to_end_tests.cc:1107: /* Insert ourselves into the rendering
pipeline */
nit: // rather than /* */

[nisse-webrtc, 2017-02-07 10:50:51]

https://codereview.webrtc.org/2678343002/diff/1/webrtc/video/end_to_end_tests.cc
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2678343002/diff/1/webrtc/video/end_to_end_tests...
webrtc/video/end_to_end_tests.cc:1107: /* Insert ourselves into the rendering
pipeline */
On 2017/02/07 09:52:03, språng wrote:
> nit: // rather than /* */

Done.

[tommi, 2017-02-07 11:58:20]

awesome :D lgtm!  couple of requests below but thanks for taking care of this.

https://codereview.webrtc.org/2678343002/diff/20001/webrtc/video/end_to_end_t...
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2678343002/diff/20001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:1108: orig_renderer_ =
(*receive_configs)[0].renderer;
first DCHECK_EQ(nullptr, orig_renderer_);

after assignment, it would also be nice to:

DCHECK_NE(nullptr, orig_renderer_);

https://codereview.webrtc.org/2678343002/diff/20001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:1158: rtc::VideoSinkInterface<VideoFrame>*
orig_renderer_;
initialize to nullptr

https://codereview.webrtc.org/2678343002/diff/20001/webrtc/video/video_stream...
File webrtc/video/video_stream_decoder.h (left):

https://codereview.webrtc.org/2678343002/diff/20001/webrtc/video/video_stream...
webrtc/video/video_stream_decoder.h:107: I420FrameCallback* const
pre_render_callback_;
w00t! :D thanks for removing this

[nisse-webrtc, 2017-02-07 13:30:59]

https://codereview.webrtc.org/2678343002/diff/20001/webrtc/video/end_to_end_t...
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2678343002/diff/20001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:1108: orig_renderer_ =
(*receive_configs)[0].renderer;
On 2017/02/07 11:58:20, tommi (webrtc) wrote:
> first DCHECK_EQ(nullptr, orig_renderer_);
> 
> after assignment, it would also be nice to:
> 
> DCHECK_NE(nullptr, orig_renderer_);

Added DCHECK. DCHECK_NE and DCHECK_EQ doesn't work with nullptr, the compiler
complains "use of overloaded operator '<<' is ambiguous".

https://codereview.webrtc.org/2678343002/diff/20001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:1158: rtc::VideoSinkInterface<VideoFrame>*
orig_renderer_;
On 2017/02/07 11:58:20, tommi (webrtc) wrote:
> initialize to nullptr

Done.

https://codereview.webrtc.org/2678343002/diff/20001/webrtc/video/video_stream...
File webrtc/video/video_stream_decoder.h (left):

https://codereview.webrtc.org/2678343002/diff/20001/webrtc/video/video_stream...
webrtc/video/video_stream_decoder.h:107: I420FrameCallback* const
pre_render_callback_;
On 2017/02/07 11:58:20, tommi (webrtc) wrote:
> w00t! :D thanks for removing this

My pleasure ;-)

[nisse-webrtc, 2017-02-07 13:46:10]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2017-02-07 13:46:10]

The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org,
tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2678343002/#ps40001 (title:
"Added nullptr initialization and DCHECKs")

[commit-bot: I haz the power, 2017-02-07 13:46:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-07 14:44:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 14:44:59]

Try jobs failed on following builders:
  linux_memcheck on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/4903)

[nisse-webrtc, 2017-02-07 15:43:20]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-02-07 15:43:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-07 15:47:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 15:47:17]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/13150)

[nisse-webrtc, 2017-02-07 15:56:41]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2017-02-07 15:56:41]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
sprang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2678343002/#ps60001 (title:
"Rebased.")

[commit-bot: I haz the power, 2017-02-07 15:56:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-07 17:37:42]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486483001314060,
"parent_rev": "cd195bea5e38a61e73b08f82445560d9136cd9da", "commit_rev":
"76bc8e858ff288449163c97aa66928f2eecdfd28"}

[commit-bot: I haz the power, 2017-02-07 17:37:45]

Description was changed from

==========
Delete VideoReceiveStream::Config::pre_render_callback.

Also delete the class I420FrameCallback.

BUG=webrtc:7124
==========

to

==========
Delete VideoReceiveStream::Config::pre_render_callback.

Also delete the class I420FrameCallback.

BUG=webrtc:7124

Review-Url: https://codereview.webrtc.org/2678343002
Cr-Commit-Position: refs/heads/master@{#16478}
Committed:
https://chromium.googlesource.com/external/webrtc/+/76bc8e858ff288449163c97aa...
==========

[commit-bot: I haz the power, 2017-02-07 17:37:46]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/76bc8e858ff288449163c97aa...