Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2677613002: Fix Chromium FYI bot breakage caused by ICE interface change (Closed)

Created:
3 years, 10 months ago by skvlad
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Chromium FYI bot Fixes the Chromium FYI breakage introduced by https://codereview.webrtc.org/2670113002 BUG=webrtc:7099 R=deadbeef@webrtc.org Review-Url: https://codereview.webrtc.org/2677613002 . Cr-Commit-Position: refs/heads/master@{#16427} Committed: https://chromium.googlesource.com/external/webrtc/+/4b512d7e0c1d342f50b47c304bbcdd06f6564754

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/p2p/base/mockicetransport.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
skvlad
3 years, 10 months ago (2017-02-03 01:42:27 UTC) #3
Taylor Brandstetter
lgtm
3 years, 10 months ago (2017-02-03 01:47:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2677613002/20001
3 years, 10 months ago (2017-02-03 01:51:19 UTC) #8
skvlad
3 years, 10 months ago (2017-02-03 02:22:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4b512d7e0c1d342f50b47c304bbcdd06f6564754 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698