Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2676983003: Adds debuggable=true to AppRTCMobile manifest (Closed)

Created:
3 years, 10 months ago by henrika_webrtc
Modified:
3 years, 10 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add debuggable=true to AppRTCMobile manifest. Improves possibility to debug the demo application using adb. As an example, now allows 'adb run as' which is useful when profiling CPU. It enables us to do profiling on non-rooted devices (excluding details). BUG=NONE Review-Url: https://codereview.webrtc.org/2676983003 Cr-Commit-Position: refs/heads/master@{#16446} Committed: https://chromium.googlesource.com/external/webrtc/+/447dba958681dc3054c3fd92ef571176ab52c279

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M webrtc/examples/androidapp/AndroidManifest.xml View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
henrika_webrtc
PTAL
3 years, 10 months ago (2017-02-06 11:50:03 UTC) #3
magjed_webrtc
lgtm
3 years, 10 months ago (2017-02-06 12:50:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2676983003/1
3 years, 10 months ago (2017-02-06 12:55:47 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 12:58:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/447dba958681dc3054c3fd92e...

Powered by Google App Engine
This is Rietveld 408576698