Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2676293003: Fix SDP parsing crash due to missing track ID in "a=msid". (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix SDP parsing crash due to missing track ID in "a=msid". BUG=chromium:686405 Review-Url: https://codereview.webrtc.org/2676293003 Cr-Commit-Position: refs/heads/master@{#16545} Committed: https://chromium.googlesource.com/external/webrtc/+/a4549d6588207a22ec0c5decc2dfc9fc9a1cde70

Patch Set 1 #

Total comments: 2

Patch Set 2 : Test for stream id #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M webrtc/pc/webrtcsdp.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/pc/webrtcsdp_unittest.cc View 1 2 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
pthatcher1
https://codereview.webrtc.org/2676293003/diff/1/webrtc/pc/webrtcsdp_unittest.cc File webrtc/pc/webrtcsdp_unittest.cc (right): https://codereview.webrtc.org/2676293003/diff/1/webrtc/pc/webrtcsdp_unittest.cc#newcode3430 webrtc/pc/webrtcsdp_unittest.cc:3430: // https://bugs.chromium.org/p/chromium/issues/detail?id=686405 Do we need a test for a ...
3 years, 10 months ago (2017-02-10 18:14:30 UTC) #2
Taylor Brandstetter
https://codereview.webrtc.org/2676293003/diff/1/webrtc/pc/webrtcsdp_unittest.cc File webrtc/pc/webrtcsdp_unittest.cc (right): https://codereview.webrtc.org/2676293003/diff/1/webrtc/pc/webrtcsdp_unittest.cc#newcode3430 webrtc/pc/webrtcsdp_unittest.cc:3430: // https://bugs.chromium.org/p/chromium/issues/detail?id=686405 On 2017/02/10 18:14:30, pthatcher1 wrote: > Do ...
3 years, 10 months ago (2017-02-10 18:29:12 UTC) #3
pthatcher1
lgtm
3 years, 10 months ago (2017-02-10 23:35:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2676293003/40001
3 years, 10 months ago (2017-02-11 00:43:48 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 01:26:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/a4549d6588207a22ec0c5decc...

Powered by Google App Engine
This is Rietveld 408576698