RTCIceCandidatePairStats.available[Outgoing/Incoming]Bitrate collected.

webrtc/pc/rtcstats_integrationtest.cc

Index: webrtc/pc/rtcstats_integrationtest.cc
diff --git a/webrtc/pc/rtcstats_integrationtest.cc b/webrtc/pc/rtcstats_integrationtest.cc
index 577504728786c476bad527e76bb3c54921859feb..128919c3b42e55931577ce6a10f3d84eab05e88d 100644
--- a/webrtc/pc/rtcstats_integrationtest.cc
+++ b/webrtc/pc/rtcstats_integrationtest.cc
@@ -369,8 +369,18 @@ class RTCStatsReportVerifier {
     verifier.TestMemberIsUndefined(candidate_pair.total_round_trip_time);
     verifier.TestMemberIsNonNegative<double>(
         candidate_pair.current_round_trip_time);
-    verifier.TestMemberIsUndefined(candidate_pair.available_outgoing_bitrate);
-    verifier.TestMemberIsUndefined(candidate_pair.available_incoming_bitrate);
+    if (candidate_pair.available_outgoing_bitrate.is_defined()) {

[hta-webrtc, 2017/02/07 11:34:37]

This isn't quite nice, because any implementation that doesn't populate the
avaiable bitrates will pass.
Is it possible to define conditions under which this *should* be defined, and
test for those rather than on whether it's present?

[hbos, 2017/02/07 13:22:11]

Yes! Updated the code to check if (selected pair) defined; else undefined;

This worked for outgoing bitrate, but incoming is always undefined. Digging
deeper, this value is a variable that is never set under any circumstances (and
indeed, the value in old stats is 0 on sample websites).

So... I'm leaving it wired up in case the incoming bitrate is fixed for the old
stats, but I added a TODO about it and the integration test expects it to be
undefined.

+      verifier.TestMemberIsNonNegative<double>(
+          candidate_pair.available_outgoing_bitrate);
+    } else {
+      verifier.TestMemberIsUndefined(candidate_pair.available_outgoing_bitrate);
+    }
+    if (candidate_pair.available_incoming_bitrate.is_defined()) {
+      verifier.TestMemberIsNonNegative<double>(
+          candidate_pair.available_incoming_bitrate);
+    } else {
+      verifier.TestMemberIsUndefined(candidate_pair.available_incoming_bitrate);
+    }
     verifier.TestMemberIsNonNegative<uint64_t>(
         candidate_pair.requests_received);
     verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.requests_sent);