RTCIceCandidatePairStats.available[Outgoing/Incoming]Bitrate collected.

webrtc/pc/rtcstats_integrationtest.cc

 /*
  *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 351 matching lines @@
     verifier.TestMemberIsDefined(candidate_pair.state);
     verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.priority);
     verifier.TestMemberIsUndefined(candidate_pair.nominated);
     verifier.TestMemberIsDefined(candidate_pair.writable);
     verifier.TestMemberIsUndefined(candidate_pair.readable);
     verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.bytes_sent);
     verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.bytes_received);
     verifier.TestMemberIsUndefined(candidate_pair.total_round_trip_time);
     verifier.TestMemberIsNonNegative<double>(
         candidate_pair.current_round_trip_time);
-    verifier.TestMemberIsUndefined(candidate_pair.available_outgoing_bitrate);
-    verifier.TestMemberIsUndefined(candidate_pair.available_incoming_bitrate);
+    if (candidate_pair.available_outgoing_bitrate.is_defined()) {

[hta-webrtc, 2017/02/07 11:34:37]

This isn't quite nice, because any implementation that doesn't populate the
avaiable bitrates will pass.
Is it possible to define conditions under which this *should* be defined, and
test for those rather than on whether it's present?

[hbos, 2017/02/07 13:22:11]

Yes! Updated the code to check if (selected pair) defined; else undefined;

This worked for outgoing bitrate, but incoming is always undefined. Digging
deeper, this value is a variable that is never set under any circumstances (and
indeed, the value in old stats is 0 on sample websites).

So... I'm leaving it wired up in case the incoming bitrate is fixed for the old
stats, but I added a TODO about it and the integration test expects it to be
undefined.

+      verifier.TestMemberIsNonNegative<double>(
+          candidate_pair.available_outgoing_bitrate);
+    } else {
+      verifier.TestMemberIsUndefined(candidate_pair.available_outgoing_bitrate);
+    }
+    if (candidate_pair.available_incoming_bitrate.is_defined()) {
+      verifier.TestMemberIsNonNegative<double>(
+          candidate_pair.available_incoming_bitrate);
+    } else {
+      verifier.TestMemberIsUndefined(candidate_pair.available_incoming_bitrate);
+    }
     verifier.TestMemberIsNonNegative<uint64_t>(
         candidate_pair.requests_received);
     verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.requests_sent);
     verifier.TestMemberIsNonNegative<uint64_t>(
         candidate_pair.responses_received);
     verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.responses_sent);
     verifier.TestMemberIsUndefined(candidate_pair.retransmissions_received);
     verifier.TestMemberIsUndefined(candidate_pair.retransmissions_sent);
     verifier.TestMemberIsUndefined(candidate_pair.consent_requests_received);
     verifier.TestMemberIsNonNegative<uint64_t>(
@@ skipping 241 matching lines @@
   caller_ = nullptr;
   // Any pending stats requests should have completed in the act of destroying
   // the peer connection.
   EXPECT_TRUE(stats_obtainer->report());
 }
 #endif  // HAVE_SCTP
 
 }  // namespace
 
 }  // namespace webrtc