Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2675863004:
Ensure that AEC3 is not run in tandem with AEC2 (Closed)
|
Created:
3 years, 10 months ago by peah-webrtc Modified:
3 years, 10 months ago CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionEnsure that AEC3 is not run in tandem with AEC2
AEC3 and AEC2 are separate submodules in APM. This CL ensures that AEC3
deactivates AEC2 if both are active at the same time.
BUG=webrtc:6018
Review-Url: https://codereview.webrtc.org/2675863004
Cr-Commit-Position: refs/heads/master@{#16443}
Committed: https://chromium.googlesource.com/external/webrtc/+/61202ac2eac69441fc1dced5e3df10b409e3dc87
Patch Set 1 #
Total comments: 2
Messages
Total messages: 15 (7 generated)
peah@webrtc.org changed reviewers: + aleloi@webrtc.org, henrik.lundin@webrtc.org
lgtm https://codereview.webrtc.org/2675863004/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/audio_processing_impl.cc (left): https://codereview.webrtc.org/2675863004/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/audio_processing_impl.cc:1192: RETURN_ON_ERR(public_submodules_->echo_cancellation->ProcessCaptureAudio( Did we rely on that public_submodules_->echo_cancellation->enabled_ was false previously?
https://codereview.webrtc.org/2675863004/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/audio_processing_impl.cc (left): https://codereview.webrtc.org/2675863004/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/audio_processing_impl.cc:1192: RETURN_ON_ERR(public_submodules_->echo_cancellation->ProcessCaptureAudio( On 2017/02/03 15:24:11, aleloi wrote: > Did we rely on that public_submodules_->echo_cancellation->enabled_ was false > previously? Yes we did.
On 2017/02/04 22:57:28, peah-webrtc wrote: > https://codereview.webrtc.org/2675863004/diff/1/webrtc/modules/audio_processi... > File webrtc/modules/audio_processing/audio_processing_impl.cc (left): > > https://codereview.webrtc.org/2675863004/diff/1/webrtc/modules/audio_processi... > webrtc/modules/audio_processing/audio_processing_impl.cc:1192: > RETURN_ON_ERR(public_submodules_->echo_cancellation->ProcessCaptureAudio( > On 2017/02/03 15:24:11, aleloi wrote: > > Did we rely on that public_submodules_->echo_cancellation->enabled_ was false > > previously? > > Yes we did. In the CL description: "deativates" -> "deactivates".
lgtm
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by peah@webrtc.org
Description was changed from ========== Ensure that AEC3 is not run in tandem with AEC2 AEC3 and AEC2 are separate submodules in APM. This CL ensures that AEC3 deativates AEC2 if both are active at the same time. BUG=webrtc:6018 ========== to ========== Ensure that AEC3 is not run in tandem with AEC2 AEC3 and AEC2 are separate submodules in APM. This CL ensures that AEC3 deactivates AEC2 if both are active at the same time. BUG=webrtc:6018 ==========
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486380405382230, "parent_rev":
"237e1bbf76a412b3e75fbe36ecd792fb8dbc51b6", "commit_rev":
"61202ac2eac69441fc1dced5e3df10b409e3dc87"}
Message was sent while issue was closed.
Description was changed from ========== Ensure that AEC3 is not run in tandem with AEC2 AEC3 and AEC2 are separate submodules in APM. This CL ensures that AEC3 deactivates AEC2 if both are active at the same time. BUG=webrtc:6018 ========== to ========== Ensure that AEC3 is not run in tandem with AEC2 AEC3 and AEC2 are separate submodules in APM. This CL ensures that AEC3 deactivates AEC2 if both are active at the same time. BUG=webrtc:6018 Review-Url: https://codereview.webrtc.org/2675863004 Cr-Commit-Position: refs/heads/master@{#16443} Committed: https://chromium.googlesource.com/external/webrtc/+/61202ac2eac69441fc1dced5e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/61202ac2eac69441fc1dced5e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
