Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 2675723002: Remove all occurrences of "using std::string". (Closed)

Created:
3 years, 10 months ago by ehmaldonado_webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, zhuangzesen_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove all occurrences of "using std::string". BUG=webrtc:7104 NOTRY=True Review-Url: https://codereview.webrtc.org/2675723002 Cr-Commit-Position: refs/heads/master@{#16418} Committed: https://chromium.googlesource.com/external/webrtc/+/1dffc62843286148288f482ef77d98342ba7d3d3

Patch Set 1 #

Messages

Total messages: 19 (10 generated)
ehmaldonado_webrtc
3 years, 10 months ago (2017-02-02 15:02:10 UTC) #2
hlundin-webrtc
Drive-by lgtm.
3 years, 10 months ago (2017-02-02 15:05:38 UTC) #4
henrika_webrtc
LGTM but the title can be improved since you actually mean "using std::string" and not ...
3 years, 10 months ago (2017-02-02 15:07:11 UTC) #5
ehmaldonado_webrtc
On 2017/02/02 15:07:11, henrika_webrtc wrote: > LGTM but the title can be improved since you ...
3 years, 10 months ago (2017-02-02 15:11:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2675723002/1
3 years, 10 months ago (2017-02-02 15:11:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12963)
3 years, 10 months ago (2017-02-02 15:15:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2675723002/1
3 years, 10 months ago (2017-02-02 16:07:44 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/1dffc62843286148288f482ef77d98342ba7d3d3
3 years, 10 months ago (2017-02-02 16:10:05 UTC) #18
kjellander_webrtc
3 years, 10 months ago (2017-02-02 16:58:46 UTC) #19
Message was sent while issue was closed.
On 2017/02/02 16:10:05, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/webrtc/+/1dffc62843286148288f482ef...

lgtm but we need a PRESUBMIT.py check to prevent it from coming back as well

Powered by Google App Engine
This is Rietveld 408576698