Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2675713005: Make rtcp packets copyable (Closed)

Created:
3 years, 10 months ago by danilchap
Modified:
3 years, 10 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make rtcp packets copyable That would simplify their usage in tests where perfomance is not critical. BUG=None Review-Url: https://codereview.webrtc.org/2675713005 Cr-Commit-Position: refs/heads/master@{#16461} Committed: https://chromium.googlesource.com/external/webrtc/+/4a9a595ab463c02ce5eadc787c9a324b571ab622

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -48 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/app.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_reports.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/nack.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rapid_resync_request.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/rpsi.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sli.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbn.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/tmmbr.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
danilchap
3 years, 10 months ago (2017-02-06 14:50:42 UTC) #2
sprang_webrtc
lgtm Optionally, we may want to explicitly declare copy ctor and assignment operator then?
3 years, 10 months ago (2017-02-06 15:02:35 UTC) #3
danilchap
Prefer to dodge style in this case, since I'm not sure explicit copy constructors would ...
3 years, 10 months ago (2017-02-07 09:07:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2675713005/1
3 years, 10 months ago (2017-02-07 09:07:28 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 09:53:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/4a9a595ab463c02ce5eadc787...

Powered by Google App Engine
This is Rietveld 408576698