Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 2675583003: RTCRTPStreamStats.ssrc changed type to uint32_t. (Closed)

Created:
3 years, 10 months ago by hbos
Modified:
3 years, 10 months ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCRTPStreamStats.ssrc changed type to uint32_t. As per PR: https://github.com/w3c/webrtc-stats/pull/157 BUG=webrtc:7065, webrtc:7066 Review-Url: https://codereview.webrtc.org/2675583003 Cr-Commit-Position: refs/heads/master@{#16471} Committed: https://chromium.googlesource.com/external/webrtc/+/3443bb75a08811a16fd2dd406f72878703f4a861

Patch Set 1 #

Patch Set 2 : Rebase with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M webrtc/api/stats/rtcstats_objects.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/rtcstatscollector.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/pc/rtcstatscollector_unittest.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
hbos
Please take a look, hta.
3 years, 10 months ago (2017-02-02 14:40:15 UTC) #4
hta-webrtc
lgtm
3 years, 10 months ago (2017-02-07 11:08:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2675583003/1
3 years, 10 months ago (2017-02-07 12:05:27 UTC) #9
commit-bot: I haz the power
Failed to apply patch for webrtc/pc/rtcstatscollector.cc: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-07 13:06:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2675583003/20001
3 years, 10 months ago (2017-02-07 13:28:05 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 14:28:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/3443bb75a08811a16fd2dd406...

Powered by Google App Engine
This is Rietveld 408576698