Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2675283003: Reland of Improve and re-enable FEC end-to-end tests. (Closed)

Created:
3 years, 10 months ago by brandtr
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Improve and re-enable FEC end-to-end tests. (patchset #1 id:1 of https://codereview.webrtc.org/2672373002/ ) Reason for revert: Will try to reland FlexFEC tests, since these do not seem to be flaky on the buildbots. Original issue's description: > Revert of Improve and re-enable FEC end-to-end tests. (patchset #3 id:40001 of https://codereview.webrtc.org/2675573004/ ) > > Reason for revert: > Ulpfec tests are still flaky on buildbots. > > Original issue's description: > > Improve and re-enable FEC end-to-end tests. > > > > These tests got flaky under the new jitter buffer. > > > > Enhancements: > > - Use send-side BWE. > > - Let BWE ramp up before applying packet loss. > > - Improve packet loss simulation for ULPFEC. > > - Add delay to fake network pipe for FlexFEC. > > (Not added for ULPFEC, since this makes those flaky...?) > > - Add FlexFEC+NACK test, using RTX instead of "raw retransmits". > > - Tighter checks of received packets' payload types and SSRCs. > > > > TESTED= > > $ ninja -C out/Debug video_engine_tests && third_party/gtest-parallel/gtest-parallel -r 1000 out/Debug/video_engine_tests --gtest_filter="*EndToEnd*Ulpfec*:*EndToEnd*Flexfec*" > > ninja: Entering directory `out/Debug' > > ninja: no work to do. > > [12000/12000] TestWithNewVideoJitterBuffer/EndToEndTest.RecoversWithFlexfecAndNack/1 (14935 ms) > > > > BUG=webrtc:7047 > > > > Review-Url: https://codereview.webrtc.org/2675573004 > > Cr-Commit-Position: refs/heads/master@{#16449} > > Committed: https://chromium.googlesource.com/external/webrtc/+/d40b0f39e08bf0e4d7427bf73b4e3f86bbeb34be > > TBR=stefan@webrtc.org,nisse@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7047 > > Review-Url: https://codereview.webrtc.org/2672373002 > Cr-Commit-Position: refs/heads/master@{#16450} > Committed: https://chromium.googlesource.com/external/webrtc/+/fd8d2654d704afa80c2fcecff5f3092c381ed249 TBR=stefan@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7047 Review-Url: https://codereview.webrtc.org/2675283003 Cr-Commit-Position: refs/heads/master@{#16452} Committed: https://chromium.googlesource.com/external/webrtc/+/1134b7b9184bb2422a81dbdbeaf1f011ecffa184

Patch Set 1 #

Patch Set 2 : Enable only FlexFEC tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -78 lines) Patch
M webrtc/video/end_to_end_tests.cc View 1 9 chunks +126 lines, -78 lines 0 comments Download

Messages

Total messages: 14 (11 generated)
brandtr
Created Reland of Improve and re-enable FEC end-to-end tests.
3 years, 10 months ago (2017-02-06 14:31:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2675283003/40001
3 years, 10 months ago (2017-02-06 14:35:44 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 14:35:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/1134b7b9184bb2422a81dbdbe...

Powered by Google App Engine
This is Rietveld 408576698