Fixing SDP parsing crash due to invalid port numbers.

Fixing SDP parsing crash due to invalid port numbers.

BUG=chromium:677029
Review-Url: https://codereview.webrtc.org/2675273003
Cr-Commit-Position: refs/heads/master@{#16541}
Committed: https://chromium.googlesource.com/external/webrtc/+/90f1e1e0d7f7b88eb5bd849bbe6a75c6778c3bc8

[pthatcher1, 2017-02-10 18:13:32]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2017-02-10 18:13:33]

lgtm, with suggestion for minor improvement

https://codereview.webrtc.org/2675273003/diff/1/webrtc/pc/webrtcsdp.cc
File webrtc/pc/webrtcsdp.cc (right):

https://codereview.webrtc.org/2675273003/diff/1/webrtc/pc/webrtcsdp.cc#newcod...
webrtc/pc/webrtcsdp.cc:1078: if (port < 0 || port > 65535) {
Might as well make an IsValidPort() function.

[Taylor Brandstetter, 2017-02-10 19:25:30]

https://codereview.webrtc.org/2675273003/diff/1/webrtc/pc/webrtcsdp.cc
File webrtc/pc/webrtcsdp.cc (right):

https://codereview.webrtc.org/2675273003/diff/1/webrtc/pc/webrtcsdp.cc#newcod...
webrtc/pc/webrtcsdp.cc:1078: if (port < 0 || port > 65535) {
On 2017/02/10 18:13:33, pthatcher1 wrote:
> Might as well make an IsValidPort() function.

Done.

[Taylor Brandstetter, 2017-02-10 19:25:37]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-02-10 19:25:37]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2675273003/#ps20001 (title:
"IsValidPort function")

[commit-bot: I haz the power, 2017-02-10 19:25:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-10 20:35:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486754737223710,
"parent_rev": "612a497d81f22ca7da1d8fa0582e4e24fb4d8813", "commit_rev":
"90f1e1e0d7f7b88eb5bd849bbe6a75c6778c3bc8"}

[commit-bot: I haz the power, 2017-02-10 20:35:08]

Description was changed from

==========
Fixing SDP parsing crash due to invalid port numbers.

BUG=chromium:677029
==========

to

==========
Fixing SDP parsing crash due to invalid port numbers.

BUG=chromium:677029

Review-Url: https://codereview.webrtc.org/2675273003
Cr-Commit-Position: refs/heads/master@{#16541}
Committed:
https://chromium.googlesource.com/external/webrtc/+/90f1e1e0d7f7b88eb5bd849bb...
==========

[commit-bot: I haz the power, 2017-02-10 20:35:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/90f1e1e0d7f7b88eb5bd849bb...

[Taylor Brandstetter, 2017-02-10 21:00:04]

Incorrect bug number; was meant to reference
https://bugs.chromium.org/p/chromium/issues/detail?id=686405