Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2674663002: Objective-C API to set the ICE check rate through RTCConfiguration. (Closed)

Created:
3 years, 10 months ago by skvlad
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Objective-C API to set the ICE check rate through RTCConfiguration. This is the Objective-C counterpart to https://codereview.webrtc.org/2670053002/. Allows applications to control the maximum ICE check rate to match bandwidth constraints. BUG=webrtc:7082 Review-Url: https://codereview.webrtc.org/2674663002 Cr-Commit-Position: refs/heads/master@{#16423} Committed: https://chromium.googlesource.com/external/webrtc/+/a5d94fff99815ef9a7e9a35fc5bc6bf17ae14f78

Patch Set 1 #

Total comments: 1

Patch Set 2 : Space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M webrtc/sdk/objc/Framework/Classes/RTCConfiguration.mm View 4 chunks +12 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
skvlad
3 years, 10 months ago (2017-02-02 07:27:14 UTC) #2
tkchin_webrtc
lgtm https://codereview.webrtc.org/2674663002/diff/1/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h (right): https://codereview.webrtc.org/2674663002/diff/1/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h#newcode108 webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h:108: * check packets. nit: align
3 years, 10 months ago (2017-02-02 19:48:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2674663002/20001
3 years, 10 months ago (2017-02-02 20:03:00 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 21:02:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/a5d94fff99815ef9a7e9a35fc...

Powered by Google App Engine
This is Rietveld 408576698