Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2670473004: Remove InlinedApi lint ignore. (Closed)

Created:
3 years, 10 months ago by sakal
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove InlinedApi lint ignore. Adds ignore for all lint errors in Chromium code. Changes minimum SDK for instrumentation tests to 16 from 14. Adds TargetApi annotations. BUG=webrtc:6597 Review-Url: https://codereview.webrtc.org/2670473004 Cr-Commit-Position: refs/heads/master@{#16412} Committed: https://chromium.googlesource.com/external/webrtc/+/f7826d668a7777f8d85c8444278a4c72c45ee8ef

Patch Set 1 : Remove InlinedApi lint ignore. #

Patch Set 2 : Immersive sticky only requires Kitkat not Lollipop. #

Messages

Total messages: 22 (15 generated)
sakal
PTAL
3 years, 10 months ago (2017-02-01 13:17:19 UTC) #6
henrika_webrtc
LGTM for WebRtcAudio*.java
3 years, 10 months ago (2017-02-01 13:27:22 UTC) #7
kjellander_webrtc
lgtm for tools-webrtc/android/suppressions.xml
3 years, 10 months ago (2017-02-01 13:58:30 UTC) #8
magjed_webrtc
lgtm
3 years, 10 months ago (2017-02-01 14:04:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2670473004/20001
3 years, 10 months ago (2017-02-01 14:11:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2670473004/40001
3 years, 10 months ago (2017-02-02 08:50:00 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 08:53:39 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/f7826d668a7777f8d85c84442...

Powered by Google App Engine
This is Rietveld 408576698