Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2670343002: Refactor and clean-up relating to RTCCodecStats. (Closed)

Created:
3 years, 10 months ago by hbos
Modified:
3 years, 10 months ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Refactor and clean-up relating to RTCCodecStats. Refactor how |codec_id| is set, remove outdated TODO, update comments with new bugs IDs. BUG=webrtc:7061 Review-Url: https://codereview.webrtc.org/2670343002 Cr-Commit-Position: refs/heads/master@{#16467} Committed: https://chromium.googlesource.com/external/webrtc/+/585a9b191c6b3f7c49fff471435dc65ffcb188ea

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -34 lines) Patch
M webrtc/api/stats/rtcstats_objects.h View 2 chunks +3 lines, -6 lines 0 comments Download
M webrtc/pc/rtcstatscollector.cc View 11 chunks +25 lines, -28 lines 2 comments Download

Messages

Total messages: 16 (12 generated)
hbos
Please take a look, this does not change any behavior. https://codereview.webrtc.org/2670343002/diff/20001/webrtc/pc/rtcstatscollector.cc File webrtc/pc/rtcstatscollector.cc (left): https://codereview.webrtc.org/2670343002/diff/20001/webrtc/pc/rtcstatscollector.cc#oldcode199 ...
3 years, 10 months ago (2017-02-03 15:18:33 UTC) #8
hta-webrtc
lgtm
3 years, 10 months ago (2017-02-07 11:23:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2670343002/20001
3 years, 10 months ago (2017-02-07 12:07:45 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 12:59:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/585a9b191c6b3f7c49fff4714...

Powered by Google App Engine
This is Rietveld 408576698