Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2670183005: Change order of tear down/create of default audio stream, to avoid starting/stopping audio card pla… (Closed)

Created:
3 years, 10 months ago by the sun
Modified:
3 years, 10 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change order of tear down/create of default audio stream, to avoid starting/stopping audio card playout unnecessarily. BUG=b/34746131 Review-Url: https://codereview.webrtc.org/2670183005 Cr-Commit-Position: refs/heads/master@{#16456} Committed: https://chromium.googlesource.com/external/webrtc/+/f748ca47b0e275b73da046734be522cbcbc6864b

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M webrtc/media/engine/webrtcvoiceengine.cc View 1 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
the sun
3 years, 10 months ago (2017-02-03 21:19:14 UTC) #2
ossu
I realize this is a quick-fix. Are you planning to add support for multiple unsignalled ...
3 years, 10 months ago (2017-02-06 13:55:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2670183005/20001
3 years, 10 months ago (2017-02-06 20:04:34 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 21:03:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/f748ca47b0e275b73da046734...

Powered by Google App Engine
This is Rietveld 408576698