Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2669463003: Suppress Memcheck:Uninitialized error when printing rtc::optional. (Closed)

Created:
3 years, 10 months ago by philipel
Modified:
3 years, 10 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Suppress Memcheck:Uninitialized error when printing rtc::optional. BUG=chromium:687087, webrtc:6822 NOTRY=True Review-Url: https://codereview.webrtc.org/2669463003 Cr-Commit-Position: refs/heads/master@{#16372} Committed: https://chromium.googlesource.com/external/webrtc/+/a7ee14ebf540e43862cefb2516f18f770230f198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools-webrtc/valgrind/memcheck/suppressions.txt View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2669463003/1
3 years, 10 months ago (2017-01-31 10:36:20 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-01-31 10:36:21 UTC) #5
philipel
3 years, 10 months ago (2017-01-31 10:37:23 UTC) #7
kjellander_webrtc
lgtm and I added NOTRY=True
3 years, 10 months ago (2017-01-31 10:38:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2669463003/1
3 years, 10 months ago (2017-01-31 10:43:40 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 10:45:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a7ee14ebf540e43862cefb251...

Powered by Google App Engine
This is Rietveld 408576698