Enable send-side BWE by default for video in call tests.

Enable send-side BWE by default for video in call tests.

Also fixes a bug where RTCP transport feedback was sent even though RTCP was disabled.

May affect perf numbers since the behavior of the send-side BWE differs a lot from the recv-side BWE.

BUG=webrtc:7111
Review-Url: https://codereview.webrtc.org/2669413003
Cr-Commit-Position: refs/heads/master@{#16451}
Committed: https://chromium.googlesource.com/external/webrtc/+/b77c716d8afc3333c8d65b2738cb645ad4ed00f7

[stefan-webrtc, 2017-02-03 10:38:24]

stefan@webrtc.org changed reviewers:
+ brandtr@webrtc.org

[stefan-webrtc, 2017-02-03 12:25:43]

.

[stefan-webrtc, 2017-02-03 12:26:29]

The CQ bit was checked by stefan@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 12:26:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-03 12:56:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 12:56:36]

Dry run: Try jobs failed on following builders:
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/19402)

[stefan-webrtc, 2017-02-03 14:06:31]

.

[stefan-webrtc, 2017-02-03 14:35:48]

.

[brandtr, 2017-02-06 13:25:25]

lgtm with nit

https://codereview.webrtc.org/2669413003/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right):

https://codereview.webrtc.org/2669413003/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:1055: return false;
Is this a bugfix? If so, consider mentioning it in the commit msg.

[brandtr, 2017-02-06 13:26:15]

On 2017/02/06 13:25:25, brandtr wrote:
> lgtm with nit
> 
>
https://codereview.webrtc.org/2669413003/diff/60001/webrtc/modules/rtp_rtcp/s...
> File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right):
> 
>
https://codereview.webrtc.org/2669413003/diff/60001/webrtc/modules/rtp_rtcp/s...
> webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:1055: return false;
> Is this a bugfix? If so, consider mentioning it in the commit msg.

Oh, and since this change might affect perf values, consider mentioning that in
the commit msg as well.

[stefan-webrtc, 2017-02-06 13:34:46]

Description was changed from

==========
Enable send-side BWE by default for video in call tests.

BUG=webrtc:7111
==========

to

==========
Enable send-side BWE by default for video in call tests.

May affect perf numbers since the behavior of the send-side BWE differs a lot
from the recv-side BWE.

BUG=webrtc:7111
==========

[stefan-webrtc, 2017-02-06 13:35:27]

Description was changed from

==========
Enable send-side BWE by default for video in call tests.

May affect perf numbers since the behavior of the send-side BWE differs a lot
from the recv-side BWE.

BUG=webrtc:7111
==========

to

==========
Enable send-side BWE by default for video in call tests.

Also fixes a bug where RTCP transport feedback was sent even though RTCP was
disabled.

May affect perf numbers since the behavior of the send-side BWE differs a lot
from the recv-side BWE.

BUG=webrtc:7111
==========

[stefan-webrtc, 2017-02-06 13:35:35]

https://codereview.webrtc.org/2669413003/diff/60001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right):

https://codereview.webrtc.org/2669413003/diff/60001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:1055: return false;
On 2017/02/06 13:25:25, brandtr wrote:
> Is this a bugfix? If so, consider mentioning it in the commit msg.

Yes

[stefan-webrtc, 2017-02-06 13:35:40]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2017-02-06 13:35:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-06 14:29:39]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486388140897860,
"parent_rev": "fd8d2654d704afa80c2fcecff5f3092c381ed249", "commit_rev":
"b77c716d8afc3333c8d65b2738cb645ad4ed00f7"}

[commit-bot: I haz the power, 2017-02-06 14:29:41]

Description was changed from

==========
Enable send-side BWE by default for video in call tests.

Also fixes a bug where RTCP transport feedback was sent even though RTCP was
disabled.

May affect perf numbers since the behavior of the send-side BWE differs a lot
from the recv-side BWE.

BUG=webrtc:7111
==========

to

==========
Enable send-side BWE by default for video in call tests.

Also fixes a bug where RTCP transport feedback was sent even though RTCP was
disabled.

May affect perf numbers since the behavior of the send-side BWE differs a lot
from the recv-side BWE.

BUG=webrtc:7111

Review-Url: https://codereview.webrtc.org/2669413003
Cr-Commit-Position: refs/heads/master@{#16451}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b77c716d8afc3333c8d65b273...
==========

[commit-bot: I haz the power, 2017-02-06 14:29:42]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/b77c716d8afc3333c8d65b273...