Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2669323003: Extends timer from 10 to 30 seconds for output volume check on Android (Closed)

Created:
3 years, 10 months ago by henrika_webrtc
Modified:
3 years, 10 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Extends timer from 10 to 30 seconds for output volume check on Android. The timer is only used for logging purposes and we can save CPU by checking the volume less often. BUG=webrtc:7096 Review-Url: https://codereview.webrtc.org/2669323003 Cr-Commit-Position: refs/heads/master@{#16430} Committed: https://chromium.googlesource.com/external/webrtc/+/4cb1b7546bd7657e051ef0b29f6b15960be7c03e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
henrika_webrtc
Trivial one-liner. PTAL
3 years, 10 months ago (2017-02-03 10:34:04 UTC) #3
henrika_webrtc
Two lines, sorry ;-)
3 years, 10 months ago (2017-02-03 10:34:24 UTC) #4
magjed_webrtc
lgtm
3 years, 10 months ago (2017-02-03 11:27:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2669323003/1
3 years, 10 months ago (2017-02-03 11:37:32 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 11:39:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/4cb1b7546bd7657e051ef0b29...

Powered by Google App Engine
This is Rietveld 408576698