Remove remaining calls to VoE APIs from Audio[Send|Receive]Stream.

Remove most of the remaining calls to VoE APIs from Audio[Send|Receive]Stream.

(TBRing webrtc/test/ OWNER)

BUG=webrtc:4690
TBR=stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/2669153004
Cr-Commit-Position: refs/heads/master@{#16455}
Committed: https://chromium.googlesource.com/external/webrtc/+/bd9a77f4e574b8e13ca4cb53fec75f239a4bd28c

[the sun, 2017-02-05 10:28:23]

Description was changed from

==========
Remove remaining calls to VoE APIs from Audio[Send|Receive]Stream.

BUG=webrtc:4690
==========

to

==========
Remove most of the remaining calls to VoE APIs from Audio[Send|Receive]Stream.

BUG=webrtc:4690
==========

[the sun, 2017-02-05 10:28:23]

solenberg@webrtc.org changed reviewers:
+ ossu@webrtc.org

[ossu, 2017-02-06 14:07:00]

lgtm

Added a comment but it's really just an FYI, in case someone comes digging
through our history.

https://codereview.webrtc.org/2669153004/diff/60001/webrtc/voice_engine/chann...
File webrtc/voice_engine/channel_proxy.cc (right):

https://codereview.webrtc.org/2669153004/diff/60001/webrtc/voice_engine/chann...
webrtc/voice_engine/channel_proxy.cc:354: // Validation code copied from
VoECodecImpl::SetSendCNPayloadType().
Not directly related to this CL, as the code is taken as-is from VoECodecImpl,
but to me it really doesn't make any sense. The relevant RFCs do not prohibit
remapping, or even duplicating, CN payload ids, though there is a static mapping
for CN/8000 to use if no signalling is performed. Eventually, I believe we want
to remove this validation, but not for this CL.

[the sun, 2017-02-06 19:35:28]

https://codereview.webrtc.org/2669153004/diff/60001/webrtc/voice_engine/chann...
File webrtc/voice_engine/channel_proxy.cc (right):

https://codereview.webrtc.org/2669153004/diff/60001/webrtc/voice_engine/chann...
webrtc/voice_engine/channel_proxy.cc:354: // Validation code copied from
VoECodecImpl::SetSendCNPayloadType().
On 2017/02/06 14:07:00, ossu wrote:
> Not directly related to this CL, as the code is taken as-is from VoECodecImpl,
> but to me it really doesn't make any sense. The relevant RFCs do not prohibit
> remapping, or even duplicating, CN payload ids, though there is a static
mapping
> for CN/8000 to use if no signalling is performed. Eventually, I believe we
want
> to remove this validation, but not for this CL.

Acknowledged.

[the sun, 2017-02-06 19:47:51]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2017-02-06 19:47:51]

The patchset sent to the CQ was uploaded after l-g-t-m from ossu@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2669153004/#ps100001 (title:
"logging bug")

[commit-bot: I haz the power, 2017-02-06 19:47:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-06 19:53:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 19:53:22]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/13089)

[the sun, 2017-02-06 20:02:34]

Description was changed from

==========
Remove most of the remaining calls to VoE APIs from Audio[Send|Receive]Stream.

BUG=webrtc:4690
==========

to

==========
Remove most of the remaining calls to VoE APIs from Audio[Send|Receive]Stream.

(TBRing webrtc/test/ OWNER)

BUG=webrtc:4690
TBR=holmer@webrtc.org
==========

[the sun, 2017-02-06 20:02:52]

Description was changed from

==========
Remove most of the remaining calls to VoE APIs from Audio[Send|Receive]Stream.

(TBRing webrtc/test/ OWNER)

BUG=webrtc:4690
TBR=holmer@webrtc.org
==========

to

==========
Remove most of the remaining calls to VoE APIs from Audio[Send|Receive]Stream.

(TBRing webrtc/test/ OWNER)

BUG=webrtc:4690
TBR=stefan@webrtc.org
==========

[the sun, 2017-02-06 20:03:02]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2017-02-06 20:03:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-06 20:53:57]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1486411382527210,
"parent_rev": "f9b6e5e4b544d235f4730644cd5641ef451cdd53", "commit_rev":
"bd9a77f4e574b8e13ca4cb53fec75f239a4bd28c"}

[commit-bot: I haz the power, 2017-02-06 20:54:01]

Description was changed from

==========
Remove most of the remaining calls to VoE APIs from Audio[Send|Receive]Stream.

(TBRing webrtc/test/ OWNER)

BUG=webrtc:4690
TBR=stefan@webrtc.org
==========

to

==========
Remove most of the remaining calls to VoE APIs from Audio[Send|Receive]Stream.

(TBRing webrtc/test/ OWNER)

BUG=webrtc:4690
TBR=stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/2669153004
Cr-Commit-Position: refs/heads/master@{#16455}
Committed:
https://chromium.googlesource.com/external/webrtc/+/bd9a77f4e574b8e13ca4cb53f...
==========

[commit-bot: I haz the power, 2017-02-06 20:54:02]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/bd9a77f4e574b8e13ca4cb53f...