Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 2669033003: Revert of Enable audio streams to send padding. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Enable audio streams to send padding. (patchset #4 id:60001 of https://codereview.webrtc.org/2652893004/ ) Reason for revert: Speculatively reverting, since Android end-to-end tests (such as https://build.chromium.org/p/client.webrtc/builders/Android64%20%28M%20Nexus5X%29) started failing. Original issue's description: > Enable audio streams to send padding. > > Useful if bitrate probing is to be used with audio streams. > > BUG=webrtc:7043 > > Review-Url: https://codereview.webrtc.org/2652893004 > Cr-Commit-Position: refs/heads/master@{#16404} > Committed: https://chromium.googlesource.com/external/webrtc/+/e35f89a484ca376d5c187d166714eba578dfadc3 TBR=mflodman@webrtc.org,danilchap@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7043 Review-Url: https://codereview.webrtc.org/2669033003 Cr-Commit-Position: refs/heads/master@{#16407} Committed: https://chromium.googlesource.com/external/webrtc/+/d3d3ba5159311296d1a190aa84d20cf1c785ba3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -50 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 4 chunks +8 lines, -25 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Taylor Brandstetter
Created Revert of Enable audio streams to send padding.
3 years, 10 months ago (2017-02-01 23:45:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2669033003/1
3 years, 10 months ago (2017-02-01 23:45:47 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 23:45:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d3d3ba5159311296d1a190aa8...

Powered by Google App Engine
This is Rietveld 408576698