Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Issue 2668963002: Remove Assert lint suppression. (Closed)

Created:
3 years, 10 months ago by sakal
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove Assert lint suppression. BUG=webrtc:6597 NOTRY=True Review-Url: https://codereview.webrtc.org/2668963002 Cr-Commit-Position: refs/heads/master@{#16460} Committed: https://chromium.googlesource.com/external/webrtc/+/1959b63b61114def922e3302b38c347ee9d9b598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools-webrtc/android/suppressions.xml View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/android/api/org/webrtc/NetworkMonitorAutoDetect.java View 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (8 generated)
sakal
PTAL
3 years, 10 months ago (2017-02-02 08:52:49 UTC) #3
kjellander_webrtc
lgtm I guess you can use NOTRY=True and just run a few Android trybots.
3 years, 10 months ago (2017-02-02 09:09:26 UTC) #4
magjed_webrtc
lgtm
3 years, 10 months ago (2017-02-02 15:57:33 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2662273004 Patch 1). Please resolve the dependency and ...
3 years, 10 months ago (2017-02-03 08:13:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2668963002/1
3 years, 10 months ago (2017-02-07 09:39:32 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 09:41:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1959b63b61114def922e3302b...

Powered by Google App Engine
This is Rietveld 408576698