Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2668743002: Fix race condition in FrameBuffer2 (Closed)

Created:
3 years, 10 months ago by philipel
Modified:
3 years, 10 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix race condition in FrameBuffer2 If the frame buffer is cleared while the decoding thread is waiting to acquire the lock in order to return the |next_frame_it| will be invalidated. BUG=chromium:679306 Review-Url: https://codereview.webrtc.org/2668743002 Cr-Commit-Position: refs/heads/master@{#16384} Committed: https://chromium.googlesource.com/external/webrtc/+/1c056254a6b8b6521ad2799c8c705b8bbfb9c210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M webrtc/modules/video_coding/frame_buffer2.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.cc View 6 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
philipel
3 years, 10 months ago (2017-01-31 16:30:50 UTC) #2
stefan-webrtc
lgtm
3 years, 10 months ago (2017-01-31 16:35:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2668743002/1
3 years, 10 months ago (2017-01-31 16:36:11 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 17:53:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1c056254a6b8b6521ad2799c8...

Powered by Google App Engine
This is Rietveld 408576698