Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2668693008: Delete VideoCaptureCapability::codecType and related logic. (Closed)

Created:
3 years, 10 months ago by nisse-webrtc
Modified:
3 years, 10 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, zhengzhonghou_agora.io, tterriberry_mozilla.com, sdk-team_agora.io, the sun, perkj_webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete VideoCaptureCapability::codecType and related logic. The video_capture module includes remnants of support for cameras producing encoded frames. However, this seems to be unused, and is explicitly not supported by VideoCaptureImpl::IncomingFrame. BUG=None Review-Url: https://codereview.webrtc.org/2668693008 Cr-Commit-Position: refs/heads/master@{#16732} Committed: https://chromium.googlesource.com/external/webrtc/+/1e3212216816cce68d873aa3ce5dea87f40414d4

Patch Set 1 #

Patch Set 2 : objc update. #

Patch Set 3 : Windows update. #

Patch Set 4 : Rebased. #

Patch Set 5 : Attempt to fix DeviceInfoImpl::GetBestMatchedCapability. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -105 lines) Patch
M webrtc/media/engine/webrtcvideocapturer.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_capture/device_info_impl.cc View 1 2 3 4 3 chunks +16 lines, -36 lines 0 comments Download
M webrtc/modules/video_capture/objc/device_info_objc.mm View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_defines.h View 1 2 3 3 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.cc View 1 2 3 2 chunks +47 lines, -56 lines 0 comments Download
M webrtc/modules/video_capture/windows/sink_filter_ds.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
nisse-webrtc
PTAL. Can we delete this code?
3 years, 10 months ago (2017-02-01 10:26:42 UTC) #2
mflodman
ltgm
3 years, 10 months ago (2017-02-17 11:12:44 UTC) #3
mflodman
Or lgtm :)
3 years, 10 months ago (2017-02-17 11:13:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2668693008/40001
3 years, 10 months ago (2017-02-17 11:23:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/18742)
3 years, 10 months ago (2017-02-17 12:06:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2668693008/60001
3 years, 10 months ago (2017-02-17 15:14:52 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/18764)
3 years, 10 months ago (2017-02-17 15:31:05 UTC) #13
nisse-webrtc
On 2017/02/17 15:31:05, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 10 months ago (2017-02-17 15:50:58 UTC) #14
nisse-webrtc
On 2017/02/17 15:50:58, nisse-webrtc wrote: > On 2017/02/17 15:31:05, commit-bot: I haz the power wrote: ...
3 years, 10 months ago (2017-02-20 15:42:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2668693008/80001
3 years, 10 months ago (2017-02-20 15:42:58 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_clang_dbg on ...
3 years, 10 months ago (2017-02-20 17:43:34 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2668693008/80001
3 years, 10 months ago (2017-02-21 07:25:02 UTC) #22
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 07:27:44 UTC) #25
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/1e3212216816cce68d873aa3c...

Powered by Google App Engine
This is Rietveld 408576698