Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2668693005: Use correct calling convention for CreateThread callback on Windows. (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use correct calling convention for CreateThread callback on Windows. It appears that thread.cc was the only thing in the webrtc codebase that was doing this incorrectly (platform_thread.cc, for instance, is ok). BUG=chromium:687251 Review-Url: https://codereview.webrtc.org/2668693005 Cr-Commit-Position: refs/heads/master@{#16387} Committed: https://chromium.googlesource.com/external/webrtc/+/dc20e265948c0e758cdfa3974f3b87d2bd248210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M webrtc/base/thread.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/base/thread.cc View 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Taylor Brandstetter
3 years, 10 months ago (2017-01-31 21:31:42 UTC) #2
tommi
Lgtm. was this passing compile because of casting?
3 years, 10 months ago (2017-01-31 22:31:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2668693005/1
3 years, 10 months ago (2017-01-31 22:31:22 UTC) #5
Taylor Brandstetter
On 2017/01/31 22:31:02, tommi (webrtc) wrote: > Lgtm. was this passing compile because of casting? ...
3 years, 10 months ago (2017-01-31 22:57:37 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 23:10:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/dc20e265948c0e758cdfa3974...

Powered by Google App Engine
This is Rietveld 408576698