Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 10 months ago by minyue-webrtc Modified:
3 years, 10 months ago Reviewers:
the sun, hlundin-webrtc, pthatcher2, pthatcher1, michaelt CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), peah-webrtc, qiang.lu, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, niklas.enbom, kwiberg-webrtc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdding build switch for Opus that supports 120ms ptime.
BUG=webrtc:7097
TEST=Set "ptime=120", try WebRTC calls over custom build Chromium with and without Opus 120ms. Try both Chromium w <-> Chromium w and Chromium w <-> Chromium w/o
Review-Url: https://codereview.webrtc.org/2668633004
Cr-Commit-Position: refs/heads/master@{#16408}
Committed: https://chromium.googlesource.com/external/webrtc/+/2e03c6611927af6ed08cf967b95342744ff329b6
Patch Set 1 #
Total comments: 5
Patch Set 2 : testing passed #Patch Set 3 : fixing a nit #Patch Set 4 : my bad, a fix needed #Patch Set 5 : nit: undo unintended format #
Created: 3 years, 10 months ago
Messages
Total messages: 35 (17 generated)
Description was changed from ========== Adding build switch for Opus that supports 120ms ptime. BUG= ========== to ========== Adding build switch for Opus that supports 120ms ptime. BUG= ==========
minyue@webrtc.org changed reviewers: + henrik.lundin@webrtc.org, michaelt@webrtc.org
Description was changed from ========== Adding build switch for Opus that supports 120ms ptime. BUG= ========== to ========== Adding build switch for Opus that supports 120ms ptime. BUG= TEST=Set "ptime=120", try WebRTC calls over custom build Chromium with and without Opus 120ms. Try both Chromium w <-> Chromium w and Chromium w <-> Chromium w/o ==========
Hi, I will do the tests as written in TEST. But please start review and let me know if you find flaws by reading it.
LG, but one nit and a question. https://codereview.webrtc.org/2668633004/diff/1/webrtc/media/engine/webrtcvoi... File webrtc/media/engine/webrtcvoiceengine.cc (right): https://codereview.webrtc.org/2668633004/diff/1/webrtc/media/engine/webrtcvoi... webrtc/media/engine/webrtcvoiceengine.cc:1480: max_packet_size_ms = 60; Is this relevant to change? https://codereview.webrtc.org/2668633004/diff/1/webrtc/webrtc.gni File webrtc/webrtc.gni (right): https://codereview.webrtc.org/2668633004/diff/1/webrtc/webrtc.gni#newcode20 webrtc/webrtc.gni:20: # Enable this if the Opus version upon which WebRTC is built support direct supports
https://codereview.webrtc.org/2668633004/diff/1/webrtc/media/engine/webrtcvoi... File webrtc/media/engine/webrtcvoiceengine.cc (right): https://codereview.webrtc.org/2668633004/diff/1/webrtc/media/engine/webrtcvoi... webrtc/media/engine/webrtcvoiceengine.cc:1480: max_packet_size_ms = 60; Will be handled in https://codereview.webrtc.org/2669733002/
LGTM with my one remaining nit. https://codereview.webrtc.org/2668633004/diff/1/webrtc/media/engine/webrtcvoi... File webrtc/media/engine/webrtcvoiceengine.cc (right): https://codereview.webrtc.org/2668633004/diff/1/webrtc/media/engine/webrtcvoi... webrtc/media/engine/webrtcvoiceengine.cc:1480: max_packet_size_ms = 60; On 2017/02/01 15:01:08, michaelt wrote: > Will be handled in https://codereview.webrtc.org/2669733002/ > Acknowledged.
On 2017/02/01 15:11:00, hlundin-webrtc wrote: > LGTM with my one remaining nit. > > https://codereview.webrtc.org/2668633004/diff/1/webrtc/media/engine/webrtcvoi... > File webrtc/media/engine/webrtcvoiceengine.cc (right): > > https://codereview.webrtc.org/2668633004/diff/1/webrtc/media/engine/webrtcvoi... > webrtc/media/engine/webrtcvoiceengine.cc:1480: max_packet_size_ms = 60; > On 2017/02/01 15:01:08, michaelt wrote: > > Will be handled in https://codereview.webrtc.org/2669733002/ > > > > Acknowledged. Thanks, but my tests show an error. I will fix. keep tuned.
minyue@webrtc.org changed reviewers: + pthatcher@webrtc.org
https://codereview.webrtc.org/2668633004/diff/1/webrtc/webrtc.gni File webrtc/webrtc.gni (right): https://codereview.webrtc.org/2668633004/diff/1/webrtc/webrtc.gni#newcode20 webrtc/webrtc.gni:20: # Enable this if the Opus version upon which WebRTC is built support direct On 2017/02/01 14:12:34, hlundin-webrtc wrote: > supports will address it. Now I fix an error and PTAL again. and I will add Peter to review.
Description was changed from ========== Adding build switch for Opus that supports 120ms ptime. BUG= TEST=Set "ptime=120", try WebRTC calls over custom build Chromium with and without Opus 120ms. Try both Chromium w <-> Chromium w and Chromium w <-> Chromium w/o ========== to ========== Adding build switch for Opus that supports 120ms ptime. BUG=webrtc:7097 TEST=Set "ptime=120", try WebRTC calls over custom build Chromium with and without Opus 120ms. Try both Chromium w <-> Chromium w and Chromium w <-> Chromium w/o ==========
pthatcher@chromium.org changed reviewers: + pthatcher@chromium.org
lgtm
lgtm
nit henrik found is fixed. commiting now
The CQ bit was checked by minyue@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from henrik.lundin@webrtc.org, pthatcher@chromium.org, michaelt@webrtc.org Link to the patchset: https://codereview.webrtc.org/2668633004/#ps40001 (title: "fixing a nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...) ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...) ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/21037)
The CQ bit was checked by minyue@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from henrik.lundin@webrtc.org, pthatcher@chromium.org, michaelt@webrtc.org Link to the patchset: https://codereview.webrtc.org/2668633004/#ps60001 (title: "my bad, a fix needed")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12926)
minyue@webrtc.org changed reviewers: + solenberg@webrtc.org
On 2017/02/01 21:15:35, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > presubmit on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12926) +the sun for VoE owner approval
On 2017/02/01 21:16:56, minyue-webrtc wrote: > On 2017/02/01 21:15:35, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > presubmit on master.tryserver.webrtc (JOB_FAILED, > > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12926) > > +the sun for VoE owner approval Why the need for a compile time flag? Is WebRTC built with different versions of Opus in native build vs. when part of Chromium?
lgtm
The CQ bit was checked by minyue@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org, henrik.lundin@webrtc.org, pthatcher@chromium.org, michaelt@webrtc.org Link to the patchset: https://codereview.webrtc.org/2668633004/#ps80001 (title: "nit: undo unintended format")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485994708249930,
"parent_rev": "d3d3ba5159311296d1a190aa84d20cf1c785ba3d", "commit_rev":
"2e03c6611927af6ed08cf967b95342744ff329b6"}
Message was sent while issue was closed.
Description was changed from ========== Adding build switch for Opus that supports 120ms ptime. BUG=webrtc:7097 TEST=Set "ptime=120", try WebRTC calls over custom build Chromium with and without Opus 120ms. Try both Chromium w <-> Chromium w and Chromium w <-> Chromium w/o ========== to ========== Adding build switch for Opus that supports 120ms ptime. BUG=webrtc:7097 TEST=Set "ptime=120", try WebRTC calls over custom build Chromium with and without Opus 120ms. Try both Chromium w <-> Chromium w and Chromium w <-> Chromium w/o Review-Url: https://codereview.webrtc.org/2668633004 Cr-Commit-Position: refs/heads/master@{#16408} Committed: https://chromium.googlesource.com/external/webrtc/+/2e03c6611927af6ed08cf967b... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/external/webrtc/+/2e03c6611927af6ed08cf967b... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
