Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2667423004: Remove the unused and untested functions from VoERTP_RTCP. (Closed)

Created:
3 years, 10 months ago by the sun
Modified:
3 years, 10 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the unused and untested functions from VoERTP_RTCP. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/2667423004 Cr-Commit-Position: refs/heads/master@{#16606} Committed: https://chromium.googlesource.com/external/webrtc/+/81d93f37a5df59eadff2d5aed3d187b78c39fcd7

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -350 lines) Patch
M webrtc/voice_engine/channel.h View 1 6 chunks +0 lines, -16 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 8 chunks +1 line, -159 lines 0 comments Download
M webrtc/voice_engine/include/voe_rtp_rtcp.h View 2 chunks +0 lines, -42 lines 0 comments Download
M webrtc/voice_engine/voe_base_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/voe_rtp_rtcp_impl.h View 2 chunks +0 lines, -24 lines 0 comments Download
M webrtc/voice_engine/voe_rtp_rtcp_impl.cc View 3 chunks +0 lines, -108 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
the sun
3 years, 10 months ago (2017-02-03 15:24:44 UTC) #2
nisse-webrtc
lgtm. Do you have a list of which classes you intend to delete completely?
3 years, 10 months ago (2017-02-06 07:28:00 UTC) #3
the sun
On 2017/02/06 07:28:00, nisse-webrtc wrote: > lgtm. > > Do you have a list of ...
3 years, 10 months ago (2017-02-06 19:27:57 UTC) #4
nisse-webrtc
You're waiting for M57 release notes to be published before landing?
3 years, 10 months ago (2017-02-08 08:14:19 UTC) #5
the sun
On 2017/02/08 08:14:19, nisse-webrtc wrote: > You're waiting for M57 release notes to be published ...
3 years, 10 months ago (2017-02-08 08:33:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2667423004/40001
3 years, 10 months ago (2017-02-14 10:05:56 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 11:45:05 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/81d93f37a5df59eadff2d5aed...

Powered by Google App Engine
This is Rietveld 408576698